Re: [PATCH] add a trivial patch style checker

Andi Kleen
2007-05-29T22:26:32Z

Heiko Carstens <heiko.carstens@de.ibm.com> writes:
>
> I'm talking of a specific problem where we just added a panic to the
> zfcp device driver. If that panic ever triggers we know for sure that
> memory corruption happened.
> So I'm just asking to not say in general that panic() in a device driver
> is a bad thing.

Ok there might be exceptions, but in general I still think it's true.
It probably fits the "you must be able to justify any warnings" rule.
I would still like this check to be added.

-Andi