Re: [PATCH] add a trivial patch style checker II

Andi Kleen
2007-05-31T12:08:08Z

> Yeah, that is a very sensible idea.
>
> > Possible further checks that might make sense:
> > - panic() anywhere in drivers/*
> > - externs in .c files without asmlinkage
> > - general checking that everything in a fully visible {} block is the right
> > indentation
> >

Here are some more warnings I would like to see:

- Warning for any spinlock/mutex definition that doesn't have a comment
nearby (all locks ought to be documented)
- Keep an ifdef count and give minus points for too many
- Warn about any architecture ifdefs (__i386__ etc.)
While not 100% illegal this is definitely something that needs to be
justified

-Andi