Re: [PATCH] add a trivial patch style checker II

Dave Jones
2007-05-31T20:00:47Z

On Thu, May 31, 2007 at 02:07:53PM +0200, Andi Kleen wrote:
> > Yeah, that is a very sensible idea.
> >
> > > Possible further checks that might make sense:
> > > - panic() anywhere in drivers/*
> > > - externs in .c files without asmlinkage
> > > - general checking that everything in a fully visible {} block is the right
> > > indentation
> > >
>
> Here are some more warnings I would like to see:
>
> - Warning for any spinlock/mutex definition that doesn't have a comment
> nearby (all locks ought to be documented)

Also barriers. (Probably even moreso).

Dave

--