Re: [PATCH] add a trivial patch style checker

Heiko Carstens
2007-05-29T14:22:50Z

> > > Possible further checks that might make sense:
> > > - panic() anywhere in drivers/*
> >
> > A driver should be allowed to panic. E.g. if it detects that due to a
> > firmware or driver bug memory corruption happened. IMHO the best thing
> > to do then is panic.
>
> That is not how Linux normally operates. A BUG() doesn't panic() by
> default either.
>
> And on systems with IOMMU that is exactly the wrong thing to do.
>
> Besides the problem is that bad drivers tend to badly abuse it
> (e.g. see some particular BSD derviced SCSI drivers). We definitely
> don't want any more of such code.

So you prefer random data corruption over an emergency stop?
That doesn't make much sense to me...