Re: [PATCH] add a trivial patch style checker

Jan Engelhardt
2007-05-30T08:41:11Z

On May 29 2007 15:36, Randy Dunlap wrote:
>> >>> + if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
>> >>> + print "Gotos should not be indented\n";
>> >>> + print "$herecurr";
>> >>> + $clean = 0;
>> >>> + }
>> >>
>> >> emacs generates one space label in front of a goto label. I wouldn't
>> >> outlaw this.
>> >
>> >Yep, we also now allow one space something to do with diff -p not
>> >getting confused...
>>
>> Not only diff and emacs. At least joe (joe.sf.net) is another editor
[...]
>
>That's just a joe bug then.
>
>diff no longer requires a beginning space, at least in the testing
>that I did it worked with no leading space on a label:.

But not everyone runs the latest and greatest. diffutils 2.8.7
takes /^label:/ as a marker for the @@ line.

Jan
--