Re: [PATCH] add a trivial patch style checker

Andy Whitcroft
2007-05-28T12:10:27Z

Andrew Morton wrote:
> On Sun, 27 May 2007 18:11:25 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
>
>> +#gotos aren't indented
>> + if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
>> + print "Gotos should not be indented\n";
>> + print "$herecurr";
>> + $clean = 0;
>> + }
>
> This should be "labels". Plus a lot of people do indent the labels by
> a single space to avoid confusing `diff -p', which seems a reasonable
> thing to not complain about.

Yep makes sense. Done.

-apw