Re: [PATCH -mm] 2/2: PCI: disable decode of IO/memory during BAR sizing

Jesse Barnes
2007-08-06T18:11:41Z

On Tuesday, May 29, 2007 9:05 pm Robert Hancock wrote:
> Change PCI BAR sizing to disable the decode of memory or IO, as
> appropriate, while we are writing the all-ones value to the BAR to
> determine the size. If this is not done, the device may spuriously
> decode accesses to memory areas it should not. On some Intel PCI
> Express chipsets, this breaks MMCONFIG configuration space access,
> since the memory the graphics card ends up decoding during this
> period overlaps the MMCONFIG area, and thus it steals the accesses to
> the area to do any other configuration space access, including
> changing the BAR back to its previous value.
>
> However, don't do this disabling on host bridge devices, as it is
> reported that some of them do silly things like disable CPU to RAM
> access if this is done.
>
> Based on an original patch by Jesse Barnes.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>

Robert, the PCI patches for fixing up MCFG detection/usage and probing
should go through Greg. Can you resend so we don't miss 2.6.24 this
time? (I was really hoping this stuff would get into 2.6.23, but
apparently none of the right people were Cc'd at the right time...
damn.)

You can add my sign-off to this one too.

Thanks,
Jesse