From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
linux-mips@linux-mips.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zs: Move to the serial subsystem
Date: Wed, 30 May 2007 10:54:59 +0100 [thread overview]
Message-ID: <465D49F3.7010005@shadowen.org> (raw)
In-Reply-To: <20070530011224.bf36d2df.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Tue, 29 May 2007 14:03:54 +0100 (BST) "Maciej W. Rozycki" <macro@linux-mips.org> wrote:
> Hey, you have volatiles and checkpatch.pl didn't complain. Andy, a
> reference to Documentation/volatile-considered-harmful.txt would suit.
>
> (That's
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/broken-out/volatile-considered-harmful-take-3.patch)
Added ...
Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
PATCH: XXX.eml:374:
FILE: linux-2.6.22-rc2/drivers/serial/zs.c:131:
+ volatile void __iomem *control = zport->port.membase +
[...]
I will batch up any changes to checkpatch.pl and send you them as a blob
when they get "interesting" if that suits.
-apw
next prev parent reply other threads:[~2007-05-30 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 13:03 [PATCH] zs: Move to the serial subsystem Maciej W. Rozycki
2007-05-30 8:12 ` Andrew Morton
2007-05-30 9:54 ` Andy Whitcroft [this message]
2007-05-30 10:09 ` Russell King
2007-05-30 12:06 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465D49F3.7010005@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox