From: Jiri Slaby <jirislaby@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Bill Nottingham <notting@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alsa: fix comparison of unsigned < 0
Date: Wed, 30 May 2007 13:47:44 +0200 [thread overview]
Message-ID: <465D6460.6030003@gmail.com> (raw)
In-Reply-To: <s5h7iqqhb09.wl%tiwai@suse.de>
Takashi Iwai napsal(a):
> Hi,
>
> thanks for checking this.
> They seem actually hitting some real bugs.
Bug fixes are ok, but keep on your mind this (I haven't checked if this is
the case):
http://lkml.org/lkml/2006/11/28/206
> At Wed, 30 May 2007 03:35:54 -0400,
> Bill Nottingham wrote:
>> diff -ru linux-2.6.21-old/sound/pci/ac97/ac97_patch.c linux-2.6.21/sound/pci/ac97/ac97_patch.c
>> --- linux-2.6.21-old/sound/pci/ac97/ac97_patch.c 2007-05-30 02:53:05.000000000 -0400
>> +++ linux-2.6.21/sound/pci/ac97/ac97_patch.c 2007-05-30 02:32:41.000000000 -0400
>> @@ -2086,8 +2086,7 @@
>> struct snd_ac97 *ac97 = snd_kcontrol_chip(kcontrol);
>> unsigned short val;
>>
>> - if (ucontrol->value.enumerated.item[0] > 3
>> - || ucontrol->value.enumerated.item[0] < 0)
>> + if (ucontrol->value.enumerated.item[0] > 3)
>> return -EINVAL;
>> val = ctrl2reg[ucontrol->value.enumerated.item[0]]
>> << AC97_AD198X_VREF_SHIFT;
>
> This one is fine.
[...]
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
next prev parent reply other threads:[~2007-05-30 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 7:35 [PATCH] alsa: fix comparison of unsigned < 0 Bill Nottingham
2007-05-30 10:16 ` Takashi Iwai
2007-05-30 11:47 ` Jiri Slaby [this message]
2007-05-30 13:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465D6460.6030003@gmail.com \
--to=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=notting@redhat.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox