From: Tilman Schmidt <tilman@imap.cc>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kkeil@suse.de,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/06] Use menuconfig objects 4 - ISDN part 2/6 (CONFIG_ISDN_I4L)
Date: Thu, 31 May 2007 18:16:52 +0200 [thread overview]
Message-ID: <465EF4F4.1090507@imap.cc> (raw)
In-Reply-To: <Pine.LNX.4.61.0705302137560.11140@yvahk01.tjqt.qr>
[-- Attachment #1: Type: text/plain, Size: 1754 bytes --]
Am 30.05.2007 21:38 schrieb Jan Engelhardt:
> --- linux-2.6.22-rc3-git1.orig/drivers/isdn/Kconfig
> +++ linux-2.6.22-rc3-git1/drivers/isdn/Kconfig
> @@ -21,9 +21,7 @@ menuconfig ISDN
>
> if ISDN
>
> -menu "Old ISDN4Linux"
> -
> -config ISDN_I4L
> +menuconfig ISDN_I4L
> tristate "Old ISDN4Linux (obsolete)"
> ---help---
> This driver allows you to use an ISDN-card for networking
> @@ -44,8 +42,6 @@ if ISDN_I4L
> source "drivers/isdn/i4l/Kconfig"
> endif
>
> -endmenu
> -
> comment "CAPI subsystem"
>
This results in a rather strange and inconsistent presentation in
"make xconfig", with ISDN4Linux appearing as a subtree in the left
pane but CAPI only visible in the right pane after selecting ISDN.
IMHO it looks much saner like this:
--- a/drivers/isdn/Kconfig
+++ b/drivers/isdn/Kconfig
@@ -21,8 +21,6 @@ menuconfig ISDN
if ISDN
-menu "Old ISDN4Linux"
-
config ISDN_I4L
tristate "Old ISDN4Linux (deprecated)"
---help---
@@ -44,12 +42,8 @@ if ISDN_I4L
source "drivers/isdn/i4l/Kconfig"
endif
-endmenu
-
-comment "CAPI subsystem"
-
config ISDN_CAPI
- tristate "CAPI2.0 support"
+ tristate "CAPI 2.0 subsystem"
help
This provides the CAPI (Common ISDN Application Programming
Interface, a standard making it easy for programs to access ISDN
This gives you a single entry in the left pane tree for disabling
all of ISDN with a single click, and nicely presents all of its
suboptions in the right pane once you select the tree entry.
HTH
Tilman
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]
next prev parent reply other threads:[~2007-05-31 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705301906.l4UJ62hC002388@shell0.pdx.osdl.net>
2007-05-30 19:37 ` [PATCH 01/06] Use menuconfig objects 4 - ISDN part 1/6 (CONFIG_ISDN) Jan Engelhardt
2007-05-30 19:38 ` [PATCH 02/06] Use menuconfig objects 4 - ISDN part 2/6 (CONFIG_ISDN_I4L) Jan Engelhardt
2007-05-31 16:16 ` Tilman Schmidt [this message]
2007-05-31 16:20 ` Karsten Keil
2007-05-31 19:53 ` Jan Engelhardt
2007-05-31 22:06 ` Tilman Schmidt
2007-05-30 19:39 ` [PATCH 03/06] Use menuconfig objects 4 - ISDN part 3/6 (CONFIG_ISDN_DRV_GIGASET) Jan Engelhardt
2007-05-30 19:40 ` [PATCH 04/06] Use menuconfig objects 4 - ISDN part 4/6 (CONFIG_ISDN_CAPI) Jan Engelhardt
2007-05-30 19:40 ` [PATCH 05/06] Use menuconfig objects 4 - ISDN part 5/6 (CONFIG_CAPI_AVM) Jan Engelhardt
2007-05-30 19:41 ` [PATCH 06/06] Use menuconfig objects 4 - ISDN part 6/6 (CONFIG_CAPI_EICON) Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465EF4F4.1090507@imap.cc \
--to=tilman@imap.cc \
--cc=akpm@linux-foundation.org \
--cc=jengelh@linux01.gwdg.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox