From: Eric Sandeen <sandeen@sandeen.net>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] Fix possible leakage of blocks in UDF
Date: Thu, 31 May 2007 12:46:15 -0500 [thread overview]
Message-ID: <465F09E7.7000300@sandeen.net> (raw)
In-Reply-To: <20070531174201.GB8392@cvg>
Cyrill Gorcunov wrote:
> Eric, could you please try the following:
>
> 1) declare the spinlock in the top of inode.c as
>
> DEFINE_SPINLOCK(udf_drop_lock);
>
> 2) replace in udf_drop_inode()
>
> kernel_lock -> spin_lock(&udf_drop_lock);
> kernel_unlock -> spin_unlock(&udf_drop_lock);
>
> I'm not sure if it help but you may try ;)
>
> Cyrill
>
I'm sure it'll avoid the deadlock but....
Any sense of what the BKL is actually trying to protect in this case?
Is it really only trying to prevent concurrent prealloc-discarders, or
is there more?
-Eric
next prev parent reply other threads:[~2007-05-31 17:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 16:59 [PATCH 1/2] Fix possible UDF data corruption Jan Kara
2007-05-24 17:05 ` [PATCH 2/2] Fix possible leakage of blocks in UDF Jan Kara
2007-05-24 20:36 ` Jan Kara
2007-05-30 21:46 ` Eric Sandeen
2007-05-30 22:22 ` Eric Sandeen
2007-05-31 16:48 ` Cyrill Gorcunov
2007-05-31 17:42 ` Cyrill Gorcunov
2007-05-31 17:46 ` Eric Sandeen [this message]
2007-06-01 16:49 ` Cyrill Gorcunov
2007-06-01 17:04 ` Andrew Morton
2007-06-01 17:15 ` Cyrill Gorcunov
2007-06-01 17:17 ` Eric Sandeen
2007-06-01 17:48 ` Cyrill Gorcunov
2007-06-01 17:51 ` Eric Sandeen
2007-06-01 17:52 ` Cyrill Gorcunov
2007-06-01 18:20 ` Cyrill Gorcunov
2007-06-01 21:10 ` Jan Kara
2007-06-01 21:05 ` Eric Sandeen
2007-06-01 22:37 ` Eric Sandeen
2007-06-01 22:48 ` Andrew Morton
2007-06-02 5:17 ` Eric Sandeen
2007-06-02 5:43 ` Andrew Morton
2007-06-02 6:34 ` Cyrill Gorcunov
2007-06-02 6:54 ` Andrew Morton
2007-06-02 6:59 ` Cyrill Gorcunov
2007-06-02 7:06 ` Andrew Morton
2007-06-02 14:06 ` Cyrill Gorcunov
2007-06-02 17:32 ` Andrew Morton
2007-06-02 18:57 ` Cyrill Gorcunov
2007-06-02 19:16 ` Andrew Morton
2007-06-02 20:01 ` Cyrill Gorcunov
2007-06-02 22:49 ` Andrew Morton
2007-06-03 6:28 ` Cyrill Gorcunov
2007-06-03 7:22 ` Cyrill Gorcunov
2007-06-04 15:53 ` Cyrill Gorcunov
2007-05-24 17:20 ` [PATCH 1/2] Fix possible UDF data corruption Cyrill Gorcunov
2007-05-24 18:35 ` Andrew Morton
2007-05-24 18:53 ` Cyrill Gorcunov
2007-05-24 19:23 ` Cyrill Gorcunov
2007-05-24 19:36 ` Andrew Morton
2007-05-24 19:49 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465F09E7.7000300@sandeen.net \
--to=sandeen@sandeen.net \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox