From: "H. Peter Anvin" <hpa@zytor.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
linux-kernel@vger.kernel.org, cotte@de.ibm.com, hugh@veritas.com,
neilb@suse.de, zanussi@us.ibm.com,
Linus Torvalds <torvalds@osdl.org>,
hch@infradead.org
Subject: Re: [PATCH] sendfile removal
Date: Thu, 31 May 2007 22:50:37 -0700 [thread overview]
Message-ID: <465FB3AD.5030807@zytor.com> (raw)
In-Reply-To: <20070601054120.GI32105@kernel.dk>
Jens Axboe wrote:
>>>
>> I would personally argue that sendfile() blocking on an O_NONBLOCK
>> desriptor, as opposed to returning EAGAIN, is a bug, and a fairly
>> serious such.
>
> I agree, but it's still a change in behaviour. Even if we consider the
> app buggy (it is), can we potentially break it?
>
It depends on which app it is, of course. However, I think we have to
smoke that out the hard way. I don't think we should retain a bug in
the kernel just because some unknown app might depend on that bug --
taking that to the extreme we could never fix bugs at all...
-hpa
next prev parent reply other threads:[~2007-06-01 5:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 10:33 [PATCH] sendfile removal Jens Axboe
2007-05-31 10:47 ` Jens Axboe
2007-05-31 10:47 ` Eric Dumazet
2007-05-31 10:53 ` Jens Axboe
2007-06-01 4:09 ` H. Peter Anvin
2007-06-01 5:41 ` Jens Axboe
2007-06-01 5:50 ` H. Peter Anvin [this message]
2007-06-01 7:22 ` Eric Dumazet
2007-06-01 15:52 ` H. Peter Anvin
2007-06-01 16:18 ` Linus Torvalds
2007-06-01 16:47 ` Eric Dumazet
2007-06-01 16:53 ` H. Peter Anvin
2007-06-02 15:02 ` Jens Axboe
2007-06-02 15:01 ` Jens Axboe
2007-06-02 15:40 ` Linus Torvalds
2007-06-02 16:35 ` Jens Axboe
[not found] ` <20070603130507.GA11170@mail.ustc.edu.cn>
2007-06-03 13:05 ` Fengguang Wu
[not found] ` <20070603142931.GA5916@mail.ustc.edu.cn>
2007-06-03 14:29 ` Fengguang Wu
[not found] ` <20070604004647.GA8076@mail.ustc.edu.cn>
2007-06-04 0:46 ` Fengguang Wu
2007-06-04 8:05 ` Jens Axboe
[not found] ` <20070604112214.GA7457@mail.ustc.edu.cn>
2007-06-04 11:22 ` Fengguang Wu
2007-06-01 16:22 ` Pádraig Brady
2007-05-31 10:55 ` Christoph Hellwig
2007-05-31 11:05 ` Jens Axboe
2007-05-31 12:26 ` Neil Brown
2007-05-31 12:27 ` Jens Axboe
2007-06-01 2:44 ` [PATCH] sendfile removal (nfsd update) Neil Brown
2007-06-01 5:44 ` Jens Axboe
2007-06-01 8:01 ` Jens Axboe
2007-06-01 8:15 ` [PATCH] sendfile removal Jens Axboe
2007-05-31 11:04 ` Carsten Otte
2007-05-31 11:06 ` Jens Axboe
2007-05-31 15:33 ` Tom Zanussi
2007-05-31 19:01 ` Jens Axboe
2007-05-31 17:06 ` Hugh Dickins
2007-05-31 17:31 ` Christoph Hellwig
2007-05-31 19:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465FB3AD.5030807@zytor.com \
--to=hpa@zytor.com \
--cc=cotte@de.ibm.com \
--cc=dada1@cosmosbay.com \
--cc=hch@infradead.org \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=torvalds@osdl.org \
--cc=zanussi@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox