public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Valdis.Kletnieks@vt.edu
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] document Acked-by:
Date: Thu, 31 May 2007 23:10:42 -0700	[thread overview]
Message-ID: <465FB862.207@zytor.com> (raw)
In-Reply-To: <28278.1180675923@turing-police.cc.vt.edu>

Valdis.Kletnieks@vt.edu wrote:
> On Thu, 31 May 2007 19:09:10 PDT, akpm@linux-foundation.org said:
> 
>> +If a person was not directly involved in the preparation or handling of a
>> +patch but wishes to signify and record their approval of it then they can
>> +arrange to have an Acked-by: line added to the patch's changelog.
>> +
>> +Acked-by: is often used by the maintainer of the affected code when that
>> +maintainer neither wrote, merged nor forwarded the patch themselves.
> 
> Do we want to add verbiage saying that an Acked-By: is also useful when it
> comes from somebody (likely the original reporter) who has actually tested the
> patch?

I'd rather see a Tested-By: for that.

There is a difference between a maintainer ack and a tester ok.

	-hpa

  reply	other threads:[~2007-06-01  6:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-01  2:09 [patch 1/1] document Acked-by: akpm
2007-06-01  5:32 ` Valdis.Kletnieks
2007-06-01  6:10   ` H. Peter Anvin [this message]
2007-06-01 10:53     ` John Anthony Kazos Jr.
2007-06-01 19:27       ` Krzysztof Halasa
2007-06-01 19:37         ` Scott Preece
2007-06-01 20:00           ` Andrew Morton
2007-06-01 20:04             ` Andrew Morton
2007-06-02 13:34               ` debian developer
2007-06-02 17:13                 ` Jan Engelhardt
2007-06-02 19:34                 ` Valdis.Kletnieks
2007-06-01 22:10           ` Krzysztof Halasa
2007-06-01 22:17             ` H. Peter Anvin
2007-06-01 22:42               ` Krzysztof Halasa
2007-06-02  0:37                 ` John Anthony Kazos Jr.
2007-06-02  0:56                   ` Krzysztof Halasa
2007-06-02  1:36             ` Valdis.Kletnieks
2007-06-01 17:27     ` Valdis.Kletnieks
2007-06-01 17:35       ` Andrew Morton
2007-06-01 18:14 ` Dave Jones
2007-06-01 18:22   ` Andrew Morton
2007-06-01 18:28     ` Dave Jones
2007-06-02 17:17       ` Jan Engelhardt
2007-06-02 18:00         ` John Anthony Kazos Jr.
2007-06-02 19:07           ` Sam Ravnborg
2007-06-02 14:11 ` Adrian Bunk
2007-06-02 17:47   ` Andrew Morton
2007-06-02 17:55     ` Adrian Bunk
2007-06-03  0:23     ` Krzysztof Halasa
2007-06-03  2:57     ` Scott Preece
2007-06-03  4:06       ` Randy Dunlap
2007-06-03  4:15         ` Andrew Morton
2007-06-03 18:31           ` Scott Preece

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465FB862.207@zytor.com \
    --to=hpa@zytor.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox