public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
	linux-usb@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
	Mathias Nyman <mathias.nyman@intel.com>,
	devicetree@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Rob Herring <robh+dt@kernel.org>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Grant Likely <grant.likely@linaro.org>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v3 06/20] usb: host: xhci-plat: Add support for the Armada 38x
Date: Tue, 06 May 2014 14:21:55 +0200	[thread overview]
Message-ID: <4660313.evfclGtT1x@wuerfel> (raw)
In-Reply-To: <20140506141023.715b932d@skate>

On Tuesday 06 May 2014 14:10:23 Thomas Petazzoni wrote:
> On Tue, 06 May 2014 13:57:44 +0200, Arnd Bergmann wrote:
> 
> > > Please limit this driver to mvebu arch and compile testing, i.e.
> > > 
> > >         depends on ARCH_MVEBU || COMPILE_TEST
> > 
> > I think it actually needs a dependency on MVEBU_MBUS.
> 
> That's not what we do for any of the other drivers that use the
> MVEBU_MBUS functions.

Fair enough. I guess using ARCH_MVEBU as the dependency works as well
because it implies MVEBU_MBUS. However, you can't use COMPILE_TEST
then because the driver itself needs the interfaces provided by MBUS.

It could be

	depends on ARCH_MVEBU || (MVEBU_MBUS && COMPILE_TEST)

to describe the dependency most accurately.

> > You probably need something like
> > 
> >       depends on MVEBU_MBUS=y || (MVEBU_MBUS=m && USB_XHCI=m)
> 
> MVEBU_MBUS is a bool, so there is no way is can be =m.

Yes, that helps.

	Arnd

  reply	other threads:[~2014-05-06 12:22 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06  0:13 [PATCH v3 00/20] USB support for Armada 38x and Armada 375 Gregory CLEMENT
2014-05-06  0:13 ` [PATCH v3 01/20] usb: ehci-orion: Fix clock reference leaking Gregory CLEMENT
2014-05-06 14:30   ` Alan Stern
2014-05-07  9:38     ` Thomas Petazzoni
2014-05-06  0:13 ` [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support Gregory CLEMENT
2014-05-06 13:33   ` Andrew Lunn
2014-05-07  9:40     ` Thomas Petazzoni
2014-05-07 13:21       ` Andrew Lunn
2014-05-07 13:56         ` Thomas Petazzoni
2014-05-06  0:13 ` [PATCH v3 03/20] usb: host: xhci-plat: Sort the headers in alphabetic order Gregory CLEMENT
2014-05-06  0:13 ` [PATCH v3 04/20] usb: xhci: add a platform-private field Gregory CLEMENT
2014-05-06 15:40   ` Felipe Balbi
2014-05-06  0:14 ` [PATCH v3 05/20] usb: host: xhci-plat: Add clocks support Gregory CLEMENT
2014-05-06  3:00   ` Felipe Balbi
2014-05-06 13:41   ` Jason Cooper
2014-05-07 12:26   ` Thomas Petazzoni
2014-05-06  0:14 ` [PATCH v3 06/20] usb: host: xhci-plat: Add support for the Armada 38x Gregory CLEMENT
2014-05-06 11:34   ` Bartlomiej Zolnierkiewicz
2014-05-06 11:57     ` Arnd Bergmann
2014-05-06 12:10       ` Thomas Petazzoni
2014-05-06 12:21         ` Arnd Bergmann [this message]
2014-05-06 12:42           ` Thomas Petazzoni
2014-05-06 15:39   ` Felipe Balbi
2014-05-07 10:23     ` Thomas Petazzoni
2014-05-07 15:10       ` Felipe Balbi
2014-05-07 15:14         ` Thomas Petazzoni
2014-05-06  0:14 ` [PATCH v3 07/20] xhci-platform: Add a new controller using xhci: " Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 08/20] ARM: mvebu: Add Device Tree description of xHCI hosts on " Gregory CLEMENT
2014-05-06 13:42   ` Andrew Lunn
2014-05-06  0:14 ` [PATCH v3 09/20] ARM: mvebu: Add Device Tree description of the EHCI host " Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 10/20] ARM: mvebu: Add USB3 support for " Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 11/20] ARM: configs: Add usb_xhci_mvebu to mvebu_v7_defconfig Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 12/20] ARM: configs: Add usb_xhci_mvebu to multi_v7_defconfig Gregory CLEMENT
2014-05-06 13:46   ` Jason Cooper
2014-05-06  0:14 ` [PATCH v3 13/20] usb: host: xhci-plat: Add support for the Armada 375 Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 14/20] xhci-platform: Add a new controller using xHCI: " Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 15/20] ARM: mvebu: Add Device Tree description of USB cluster controller on " Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 16/20] dt: binding: Armada 375 USB cluster Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 17/20] phy: Add support for USB cluster on the Armada 375 SoC Gregory CLEMENT
2014-05-06 11:37   ` Bartlomiej Zolnierkiewicz
2014-05-07 12:50     ` Thomas Petazzoni
2014-05-06 13:54   ` Andrew Lunn
2014-05-07 12:52     ` Thomas Petazzoni
2014-05-06 20:53   ` Ezequiel Garcia
2014-05-07 12:55     ` Thomas Petazzoni
2014-05-06  0:14 ` [PATCH v3 18/20] ARM: mvebu: Add USB3 support for Armada 375 Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 19/20] ARM: mvebu: Add Device Tree description of the xHCI host on " Gregory CLEMENT
2014-05-06  0:14 ` [PATCH v3 20/20] ARM: mvebu: Add Device Tree description of the EHCI " Gregory CLEMENT
2014-05-07  8:33 ` [PATCH v3 00/20] USB support for Armada 38x and " Hans de Goede
2014-05-07  9:21   ` Sebastian Hesselbarth
2014-05-07  9:48     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4660313.evfclGtT1x@wuerfel \
    --to=arnd@arndb.de \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=b.zolnierkie@samsung.com \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=nadavh@marvell.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tawfik@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox