Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning

Christoph Lameter
2007-06-01T23:42:19Z

On Fri, 1 Jun 2007, Linus Torvalds wrote:

> No, I don't think you can do it this way.

Ultimately not. But its worth to see if this works.

> At a minimum, you'd need to test that the result is word-aligned.
> Preferably 8-byte aligned. We literally have stuff that knows about these
> things and uses the low bits in the pointer to keep extra data.

kmalloc allocations are guaranteed to be aligned to KMALLOC_MINALIGN. I
can bring that in but it will make the patch less readable.

> Of course, there migth be other (even more subtle) cases where we just
> assume certain alignment, and depend on the fact that we just _happen_ to
> get it. Who knows..

I tried to get rid of those cased and I hope that work is complete in
2.6.22.