Re: [patch 1/1] document Acked-by:

H. Peter Anvin
2007-06-01T22:17:51Z

Krzysztof Halasa wrote:
> "Scott Preece" <sepreece@gmail.com> writes:
>
>> This is a question worth answering - is it rude to ack/nak a patch if
>> you're not a maintainer or otherwise known-to-be-trusted, or is it OK
>> for anyone to express an opinion? Andrew's patch text seems to imply
>> that it's generally OK.
>
> Every pair of eyes (or a single one) looking at the patch in question
> is a good thing. I can't imagine why would one want to look at the
> code if he/she can't ack or nak or otherwise comment it.

I think the comment had to do with the concept that ACK/NAK implies
authority. If you're not the maintainer, it's rude to imply that you
are. Obvious, test reports (good or bad!) are always welcome.

-hpa