Re: [patch 1/1] document Acked-by:

Krzysztof Halasa
2007-06-02T00:56:40Z

"John Anthony Kazos Jr." <jakj@j-a-k-j.com> writes:

> "Acked-by:" does not mean "I like this" but rather "I approve of this".

I'd say it means "I acknowledge it". If you want to express
approval, why not use some sort of "Approved-by"?

> If I put "Acked-by: John..." on a patch of any kind, even trivial, it
> would look incredibly stupid, because I'm just some guy messing around
> with the kernel. A tactful response to me doing that from any actual
> kernel bigwig would be, "I appreciate your enthusiasm, but you are not
> part of the kernel patch flow." Similarly, a tactful response to me
> NACKing a patch would be, "I appreciate your concern, but you are in no
> position to remove a patch from the stream. Your comments will be
> considered and implemented or countered by an actual maintainer."
>
> This is appropriate.

You seem to know these things very well.
--
Krzysztof Halasa