From: "H. Peter Anvin" <hpa@zytor.com>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Matthew Fredrickson <creslin@digium.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Device Driver Etiquette
Date: Fri, 01 Jun 2007 15:28:24 -0700 [thread overview]
Message-ID: <46609D88.4040806@zytor.com> (raw)
In-Reply-To: <75b66ecd0706011138v25e0d352p2fe5c4b5b8933046@mail.gmail.com>
Lee Revell wrote:
> On 6/1/07, Matthew Fredrickson <creslin@digium.com> wrote:
>> is it acceptable (although
>> not nice) to simply fix it this way, by disabling irqs while it loads
>> the firmware?
>>
>
> I would say to just disable IRQs while loading firmware. Almost every
> server I maintain has some vendor driver which generates a "many lost
> ticks!" message on load. As long as it's only done at module load
> time it should be fine.
>
> Of course the best solution is to just get the driver into mainline.
>
Disable interrupts for 5-10 seconds (see OP)? You're nuts.
That might be only a minor disaster on an SMP system, assuming IRQ
balancing sends them elsewhere, but on a uniprocessor system you're
effectively shooting the machine in the head.
It should be possible to streamline the code to not hog the stack that way.
-hpa
next prev parent reply other threads:[~2007-06-01 22:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 17:47 Device Driver Etiquette Matthew Fredrickson
2007-06-01 18:38 ` Lee Revell
2007-06-01 22:28 ` H. Peter Anvin [this message]
2007-06-02 15:05 ` Satyam Sharma
2007-06-02 23:22 ` Arjan van de Ven
2007-06-03 1:45 ` Satyam Sharma
-- strict thread matches above, loose matches on Subject: below --
2007-06-01 23:16 Daniel J Blueman
[not found] <12467610.159201180797054019.JavaMail.root@jupiler.digium.com>
2007-06-02 15:12 ` Matt Fredrickson
2007-06-03 11:22 ` Daniel J Blueman
[not found] <17916027.160971180851607681.JavaMail.root@jupiler.digium.com>
2007-06-03 6:20 ` Matt Fredrickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46609D88.4040806@zytor.com \
--to=hpa@zytor.com \
--cc=creslin@digium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox