From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757269AbXFBFSJ (ORCPT ); Sat, 2 Jun 2007 01:18:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754346AbXFBFR5 (ORCPT ); Sat, 2 Jun 2007 01:17:57 -0400 Received: from sandeen.net ([209.173.210.139]:16378 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbXFBFR4 (ORCPT ); Sat, 2 Jun 2007 01:17:56 -0400 Message-ID: <4660FD7F.4090302@sandeen.net> Date: Sat, 02 Jun 2007 00:17:51 -0500 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.0 (Macintosh/20070326) MIME-Version: 1.0 To: Andrew Morton CC: Jan Kara , linux-kernel@vger.kernel.org, Cyrill Gorcunov Subject: Re: [PATCH 2/2] Fix possible leakage of blocks in UDF References: <20070524165935.GB19709@duck.suse.cz> <20070524170554.GC19709@duck.suse.cz> <20070524203653.GA7693@duck.suse.cz> <465DF0B4.2050203@sandeen.net> <20070601211036.GA23975@duck.suse.cz> <46609FBD.5040407@sandeen.net> <20070601154834.53558d1b.akpm@linux-foundation.org> In-Reply-To: <20070601154834.53558d1b.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > On Fri, 01 Jun 2007 17:37:49 -0500 > Eric Sandeen wrote: >> going for the inode_lock twice? >> > > lockdep should catch that. > hey that's a good idea...! *sigh* sometimes I worry about myself... but hey at least I got it right. :) ============================================= [ INFO: possible recursive locking detected ] 2.6.22-rc3 #8 --------------------------------------------- lt-fsstress/3285 is trying to acquire lock: (inode_lock){--..}, at: [] __mark_inode_dirty+0xe2/0x16c but task is already holding lock: (inode_lock){--..}, at: [] _atomic_dec_and_lock+0x39/0x58 other info that might help us debug this: 3 locks held by lt-fsstress/3285: #0: (&inode->i_mutex/1){--..}, at: [] do_rmdir+0x7c/0xe3 #1: (&inode->i_mutex){--..}, at: [] mutex_lock+0x22/0x24 #2: (inode_lock){--..}, at: [] _atomic_dec_and_lock+0x39/0x58 stack backtrace: Call Trace: [] __lock_acquire+0x155/0xbaa [] __mark_inode_dirty+0xe2/0x16c [] lock_acquire+0x7b/0x9f [] __mark_inode_dirty+0xe2/0x16c [] _spin_lock+0x1e/0x28 [] __mark_inode_dirty+0xe2/0x16c [] :udf:udf_write_aext+0x101/0x11b [] :udf:extent_trunc+0xd6/0x123 [] :udf:udf_truncate_tail_extent+0xda/0x171 [] :udf:udf_drop_inode+0x26/0x35 [] iput+0x74/0x76 [] dentry_iput+0xa0/0xb8 [] prune_dcache+0xa2/0x174 [] d_kill+0x21/0x43 [] prune_one_dentry+0x3a/0xef [] prune_dcache+0xed/0x174 [] shrink_dcache_parent+0x21/0x10e [] dentry_unhash+0x26/0x84 [] vfs_rmdir+0x88/0x117 [] do_rmdir+0xa1/0xe3 [] syscall_trace_enter+0x8d/0x8f [] sys_rmdir+0x11/0x13 [] tracesys+0xdc/0xe1 -Eric