Re: [PATCH] USB: storage: fix Huawei mode switching regression

Bjørn Mork
2013-03-04T16:47:43Z

Ben Hutchings <ben@decadent.org.uk> writes:
> On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote:
> [...]
>> In-kernel mode switching was deprecated years ago with the
>> development of the more user friendly userspace alternatives. The
>> existing list of devices in usb-storage was only kept to prevent
>> breaking already working systems. The long term plan is to remove
>> the list, not to add to it. Ref:
>> http://permalink.gmane.org/gmane.linux.usb.general/28543
> [...]
>
> Can you add a comment to this effect?

In the table in unusual_devs.h, you mean? Sure, I can do that.

But it feels a bit strange since I can only quote and/or refer to what
Matthew and Greg said about the issue years ago. Putting a comment in
the code to remind the current maintainers about their own statements
could be considered out of line? Or is this appropriate here?

Bjørn