From: Jeff Garzik <jeff@garzik.org>
To: Paul Mundt <lethal@linux-sh.org>, Jeff Garzik <jeff@garzik.org>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smc91x: sh solution engine fixes.
Date: Sun, 03 Jun 2007 11:47:56 -0400 [thread overview]
Message-ID: <4662E2AC.8050004@garzik.org> (raw)
In-Reply-To: <20070601083648.GA11035@linux-sh.org>
Paul Mundt wrote:
> The current smc91x I/O routines ifdef the solution engine subtypes
> individually, which is rather bogus, as they can simply use
> CONFIG_SOLUTION_ENGINE instead. This fixes it for some of the other
> solution engines that weren't included in the ifdef list (SH7206
> specifically).
>
> There are also inb/outb definitions which are totally bogus (missing
> brackets in _both_ cases, SMC_CAN_USE_8BIT == 0, and even better, they
> try to use a 16-bit access to fake 8-bit access). Kill that nonsense off
> completely.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
applied to #upstream-fixes
prev parent reply other threads:[~2007-06-03 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 8:36 [PATCH] smc91x: sh solution engine fixes Paul Mundt
2007-06-03 15:47 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4662E2AC.8050004@garzik.org \
--to=jeff@garzik.org \
--cc=iwamatsu@nigauri.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox