public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: jschopp <jschopp@austin.ibm.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.03
Date: Mon, 04 Jun 2007 10:49:53 -0500	[thread overview]
Message-ID: <466434A1.4040905@austin.ibm.com> (raw)
In-Reply-To: <0a25fd03117c678f17006c5fcefaaed0@pinky>

> This version brings a host of changes to cure false positives and
> bugs detected on patches submitted to lkml and -mm.  It also brings
> a number of new tests in response to reviews, of particular note:
> 
>   - catch use of volatile
>   - allow deprecated functions to be listed in feature-removal-schedule.txt
>   - warn about #ifdef's in c files


I think the design philosophy of the style checker should be to err on the side of being 
quiet.  It shouldn't report things that aren't problems.  There are plenty of valid uses 
of #ifdefs in c files.  #ifdefs may be abused often.  If we start bothering every author 
that uses #ifdefs with an annoying note it detracts from the usefulness of our tool.

If we really want to complain about #ifdefs we should add a flag to the script so it isn't 
a default.  -potential or something.  We could put all the "this often is an error" type 
warnings under it.

The rest of the patch looks fine.

-Joel

  parent reply	other threads:[~2007-06-04 15:50 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04  9:46 [PATCH] update checkpatch.pl to version 0.03 Andy Whitcroft
2007-06-04  9:55 ` [PATCH] update feature-removal-schedule.txt to include deprecated functions Andy Whitcroft
2007-06-04 15:49 ` jschopp [this message]
2007-06-04 16:51   ` [PATCH] update checkpatch.pl to version 0.03 Andy Whitcroft
2007-06-04 17:22     ` jschopp
2007-06-05 18:45       ` Andy Whitcroft
2007-06-05  9:56   ` Andy Whitcroft
2007-06-04 16:25 ` Jan Engelhardt
2007-06-04 18:41 ` Andrew Morton
2007-06-04 19:08   ` Andy Whitcroft
2007-06-04 19:08     ` Rene Herman
2007-06-04 20:04       ` Randy Dunlap
2007-06-05 18:39         ` Andy Whitcroft
2007-06-08  9:31       ` Andy Whitcroft
2007-06-08 10:08         ` Rene Herman
2007-06-05  8:14 ` Heiko Carstens
2007-06-06  9:05 ` Jesper Juhl
2007-06-07 14:28   ` Jan Engelhardt
2007-06-07 14:39     ` Jesper Juhl
2007-06-07 19:34     ` Adrian Bunk
2007-06-07 22:22       ` Alan Cox
2007-06-07 23:21         ` Adrian Bunk
2007-06-07 23:41           ` Alan Cox
2007-06-08  0:04             ` Adrian Bunk
2007-06-08  4:37               ` Jon Masters
2007-06-08  8:58               ` Jan-Benedict Glaw
2007-06-08 10:52               ` Alan Cox
2007-06-08 12:39                 ` Adrian Bunk
2007-06-08 14:34                   ` Jesper Juhl
2007-06-08 14:42                     ` Adrian Bunk
2007-06-08 15:16                       ` Jan Engelhardt
2007-06-08 15:37                         ` Jon Masters
2007-06-08 15:42                         ` Alan Cox
2007-06-08 16:39                           ` Adrian Bunk
2007-06-08 18:43                             ` Jan Engelhardt
2007-06-08 16:03                     ` Roland Dreier
2007-06-07 23:49           ` Adrian Bunk
2007-06-07 19:32   ` Adrian Bunk
2007-06-07 22:18     ` Alan Cox
2007-06-06 11:49 ` Jesper Juhl
2007-06-07 11:46   ` Andy Whitcroft
2007-06-07 11:52     ` Jesper Juhl
2007-06-07 15:16       ` checkpatch.pl: should be executable Andy Whitcroft
2007-06-07 15:33         ` jschopp
2007-06-07 14:22     ` [PATCH] update checkpatch.pl to version 0.03 Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=466434A1.4040905@austin.ibm.com \
    --to=jschopp@austin.ibm.com \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox