[RFC] Documentation/CodingStyle: Add rules for goto labels

WANG Cong
2007-06-03T14:24:26Z

There are many people use Lindent to indent their code, but Lindent gets wrong when it
meets goto labels. This should be fixed manually.

And kernel's CodingStyle doesn't specify the indentation for goto labels explicitly.

This patch adds specifications on those things about goto labels in CodingStyle. And it is
against -rc3 source tree.

Any advice or comments are more than welcome!

Regards!

Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

---
CodingStyle | 6 ++++++
1 file changed, 6 insertions(+)

--- linux-2.6.22-rc3/Documentation/CodingStyle.orig 2007-06-03 21:28:19.000000000 +0800
+++ linux-2.6.22-rc3/Documentation/CodingStyle 2007-06-03 21:51:21.000000000 +0800
@@ -66,6 +66,12 @@ something to hide:
Don't put multiple assignments on a single line either. Kernel coding style
is super simple. Avoid tricky expressions.

+Do care when you use Lindent to indent your code, since it may use spaces
+instead of tabs before a goto label and it may also align the label in a
+wrong position. A goto label should be aligned in the column that is 8
+characters ahead of the statement just below this label. Please fix it manually
+if you find Lindent is wrong.
+
Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation, and the above example is deliberately broken.