Re: [RFC] Documentation/CodingStyle: Add rules for goto labels

Valdis.Kletnieks
2007-06-04T17:55:26Z

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

On Mon, 04 Jun 2007 10:43:51 PDT, "H. Peter Anvin" said:
> Jan Engelhardt wrote:
> > But gotos are special. ("Evil" minus the "it's good for unrolling in case of an
> > error" case).

> So?
>
> You still want them to be associated with the level the bailout happens at.

No, you want them associated with the level you bail out *TO*. Otherwise you
get this:

...
...
if (..) {
if (..) {
goto ka_blammo;
...
foo = yadda_yadda(.....);
kfree(bar->some_struct);
ka_blammo:
/* continue with cleanup here */

Goto labels belong in column 1. Or 2 if you believe in the existence of 'diff
-p' that get confused by col-1 labels.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]