From: Robert Hancock <hancockr@shaw.ca>
To: James Jarvis <James.Jarvis@ed.ac.uk>
Cc: Riley@Williams.Name, Linux-Kernel@vger.kernel.org,
graham.newton@ed.ac.uk, kenneth.macdonald@ed.ac.uk
Subject: Re: DMI_MATCH patch in reboot.c for SFF Dell OptiPlex 745 - fixes hang on reboot
Date: Mon, 04 Jun 2007 18:49:10 -0600 [thread overview]
Message-ID: <4664B306.5000107@shaw.ca> (raw)
In-Reply-To: <fa./cH7AY3hv2QMikoTK1P7fAVvbdI@ifi.uio.no>
James Jarvis wrote:
> I trust this is the right list...
>
> The following patch enables reboot through BIOS on the Dell Optiplex 745
> Small Form Factor base, on which reboot hangs. The larger form factor
> does not require this, hence the match on DMI_BOARD_NAME.
>
> --- arch/i386/kernel/reboot.c.orig 2007-06-01 12:22:53.000000000 +0100
> +++ arch/i386/kernel/reboot.c 2007-06-04 16:53:36.000000000 +0100
> @@ -104,6 +104,15 @@
> DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge 300/"),
> },
> },
> + { /* Handle problems with rebooting on Dell Optiplex 745's
> SFF*/
> + .callback = set_bios_reboot,
> + .ident = "Dell OptiPlex 745",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 745"),
> + DMI_MATCH(DMI_BOARD_NAME, "0WF810"),
> + },
> + },
> { /* Handle problems with rebooting on Dell 2400's */
> .callback = set_bios_reboot,
> .ident = "Dell PowerEdge 2400",
This blacklist seems to be growing. Isn't there something better we can
do here? Can we just reboot through the BIOS by default, is that really
broken on some systems?
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/
next parent reply other threads:[~2007-06-05 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa./cH7AY3hv2QMikoTK1P7fAVvbdI@ifi.uio.no>
2007-06-05 0:49 ` Robert Hancock [this message]
2007-06-05 8:42 ` DMI_MATCH patch in reboot.c for SFF Dell OptiPlex 745 - fixes hang on reboot James E. Jarvis
2007-06-05 11:55 ` Matthew Garrett
2007-06-04 16:12 James Jarvis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4664B306.5000107@shaw.ca \
--to=hancockr@shaw.ca \
--cc=James.Jarvis@ed.ac.uk \
--cc=Linux-Kernel@vger.kernel.org \
--cc=Riley@Williams.Name \
--cc=graham.newton@ed.ac.uk \
--cc=kenneth.macdonald@ed.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox