Re: DMI_MATCH patch in reboot.c for SFF Dell OptiPlex 745 - fixes hang on reboot

Robert Hancock
2007-06-05T00:49:23Z

James Jarvis wrote:
> I trust this is the right list...
>
> The following patch enables reboot through BIOS on the Dell Optiplex 745
> Small Form Factor base, on which reboot hangs. The larger form factor
> does not require this, hence the match on DMI_BOARD_NAME.
>
> --- arch/i386/kernel/reboot.c.orig 2007-06-01 12:22:53.000000000 +0100
> +++ arch/i386/kernel/reboot.c 2007-06-04 16:53:36.000000000 +0100
> @@ -104,6 +104,15 @@
> DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge 300/"),
> },
> },
> + { /* Handle problems with rebooting on Dell Optiplex 745's
> SFF*/
> + .callback = set_bios_reboot,
> + .ident = "Dell OptiPlex 745",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 745"),
> + DMI_MATCH(DMI_BOARD_NAME, "0WF810"),
> + },
> + },
> { /* Handle problems with rebooting on Dell 2400's */
> .callback = set_bios_reboot,
> .ident = "Dell PowerEdge 2400",

This blacklist seems to be growing. Isn't there something better we can
do here? Can we just reboot through the BIOS by default, is that really
broken on some systems?

--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/