[PATCH ext3/ext4] orphan list check on destroy_inode

[PATCH ext3/ext4] orphan list check on destroy_inode

[Vasily Averin]

Customers claims to ext3-related errors, investigation showed that ext3 orphan list has been corrupted and have the reference to non-ext3 inode. The following debug helps to understand the reasons of this issue.

Signed-off-by:	Vasily Averin <vvs@sw.ru>

diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 6e30629..46e2fa6 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -459,6 +459,21 @@ static struct inode *ext3_alloc_inode(struct super_block *sb)
 
 static void ext3_destroy_inode(struct inode *inode)
 {
+	if (!list_empty(&(EXT3_I(inode)->i_orphan))) {
+		int i, imax;
+		unsigned int *p;
+
+		p = (unsigned int *)EXT3_I(inode);
+		imax = sizeof(struct ext3_inode_info) / sizeof(unsigned int);
+		printk("Inode %p: orphan list check failed!\n", EXT3_I(inode));
+		for (i = 0; i < imax; i++) {
+			if (i && ((i % 8) == 0))
+				printk("\n");
+			printk("%08x ", *p++);
+		}
+		printk("\n");
+		dump_stack();
+	}
 	kmem_cache_free(ext3_inode_cachep, EXT3_I(inode));
 }
 
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index cb9afdd..f86e0ac 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -510,6 +510,21 @@ static struct inode *ext4_alloc_inode(struct super_block *sb)
 
 static void ext4_destroy_inode(struct inode *inode)
 {
+	if (!list_empty(&(EXT4_I(inode)->i_orphan))) {
+		int i, imax;
+		unsigned int *p;
+
+		p = (unsigned int *)EXT4_I(inode);
+		imax = sizeof(struct ext4_inode_info) / sizeof(unsigned int);
+		printk("Inode %p: orphan list check failed!\n", EXT4_I(inode));
+		for (i = 0; i < imax; i++) {
+			if (i && ((i % 8) == 0))
+				printk("\n");
+			printk("%08x ", *p++);
+		}
+		printk("\n");
+		dump_stack();
+	}
 	kmem_cache_free(ext4_inode_cachep, EXT4_I(inode));
 }
 

Re: [PATCH ext3/ext4] orphan list check on destroy_inode

[Andrew Morton]

On Mon, 04 Jun 2007 09:18:55 +0400 Vasily Averin <vvs@sw.ru> wrote:

> Customers claims to ext3-related errors, investigation showed that ext3 orphan list has been corrupted and have the reference to non-ext3 inode. The following debug helps to understand the reasons of this issue.
> 
> Signed-off-by:	Vasily Averin <vvs@sw.ru>
> 
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 6e30629..46e2fa6 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -459,6 +459,21 @@ static struct inode *ext3_alloc_inode(struct super_block *sb)
>  
>  static void ext3_destroy_inode(struct inode *inode)
>  {
> +	if (!list_empty(&(EXT3_I(inode)->i_orphan))) {
> +		int i, imax;
> +		unsigned int *p;
> +
> +		p = (unsigned int *)EXT3_I(inode);
> +		imax = sizeof(struct ext3_inode_info) / sizeof(unsigned int);
> +		printk("Inode %p: orphan list check failed!\n", EXT3_I(inode));
> +		for (i = 0; i < imax; i++) {
> +			if (i && ((i % 8) == 0))
> +				printk("\n");
> +			printk("%08x ", *p++);
> +		}
> +		printk("\n");
> +		dump_stack();

umm, OK, but please use the new lib/hexdump.c for this.

Re: [PATCH ext3/ext4] orphan list check on destroy_inode

[Eric Sandeen]

Vasily Averin wrote:
> Customers claims to ext3-related errors, investigation showed that ext3 orphan list has been corrupted and have the reference to non-ext3 inode. The following debug helps to understand the reasons of this issue.

Vasily, does your customer have this patch in place?

http://www.mail-archive.com/linux-ext4@vger.kernel.org/msg00889.html

If not, perhaps it could be leading to the same error, because the inode 
will not be properly removed from the orphan inode list when it is 
freed, and could then be recycled...

-Eric

Re: [PATCH ext3/ext4] orphan list check on destroy_inode

[Vasily Averin]

Eric Sandeen wrote:
> Vasily Averin wrote:
>> Customers claims to ext3-related errors, investigation showed that ext3
>> orphan list has been corrupted and have the reference to non-ext3 inode.
>> The following debug helps to understand the reasons of this issue.
> 
> Vasily, does your customer have this patch in place?
> 
> http://www.mail-archive.com/linux-ext4@vger.kernel.org/msg00889.html
> 
> If not, perhaps it could be leading to the same error, because the inode will
> not be properly removed from the orphan inode list when it is freed, and
> could then be recycled...

We did have a several bugreports occurred on the kernels without your patch, but
latest incident (when check in ext3_destroy_inode has been triggered) has been
occurred on the kernel where your patch has been applied.

Thank you,
	Vasily Averin