From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@google.com>
Cc: linux-kernel@vger.kernel.org, Ingo Korb <ingo@akana.de>
Subject: Re: [PATCH 1/3] Char: stallion, don't fail with less than max panels
Date: Wed, 06 Jun 2007 09:00:10 +0200 [thread overview]
Message-ID: <46665B7A.8020506@gmail.com> (raw)
In-Reply-To: <20070605171745.1ea5b88f.akpm@google.com>
Andrew Morton napsal(a):
> On Tue, 5 Jun 2007 23:20:57 +0200 (CEST)
> Jiri Slaby <jirislaby@gmail.com> wrote:
>
>> stallion, don't fail with less than max panels
>>
>
> Why not?
>
> What problem is this patch fixing, and how does it fix it?
>
> What are the consequences of not having this patch in the kernel?
>
> etc. More complete changlogs, please.
Aah, sorry.
--
Since it's not neccesary to have MAX_PANELS on the card, don't fail to let users
use this card even in this case. Stop the testing for loop instead.
--
>
>> diff --git a/drivers/char/stallion.c b/drivers/char/stallion.c
>> index e45113a..265abad 100644
>> --- a/drivers/char/stallion.c
>> +++ b/drivers/char/stallion.c
>> @@ -2172,7 +2172,7 @@ static int __devinit stl_initech(struct stlbrd *brdp)
>> }
>> status = inb(ioaddr + ECH_PNLSTATUS);
>> if ((status & ECH_PNLIDMASK) != nxtid)
>> - goto err_fr;
>> + break;
>> panelp = kzalloc(sizeof(struct stlpanel), GFP_KERNEL);
>> if (!panelp) {
>> printk("STALLION: failed to allocate memory "
>
thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
prev parent reply other threads:[~2007-06-06 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 21:20 [PATCH 1/3] Char: stallion, don't fail with less than max panels Jiri Slaby
2007-06-05 21:21 ` [PATCH 2/3] Char: stallion, alloc tty before pci devices init Jiri Slaby
2007-06-05 21:22 ` [PATCH 3/3] Char: stallion, proper fail return values Jiri Slaby
2007-06-05 21:27 ` [PATCH 4/3] Char: stallion, remove user class report request Jiri Slaby
2007-06-06 0:17 ` [PATCH 1/3] Char: stallion, don't fail with less than max panels Andrew Morton
2007-06-06 7:00 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46665B7A.8020506@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@google.com \
--cc=ingo@akana.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox