From: Jiri Slaby <jirislaby@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@osdl.org, linux-kernel@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH] Minor cleanups in tty_ioctl.c
Date: Wed, 06 Jun 2007 15:09:51 +0200 [thread overview]
Message-ID: <4666B21F.60508@gmail.com> (raw)
In-Reply-To: <1181133269.4096.34.camel@pmac.infradead.org>
David Woodhouse napsal(a):
> Cosmetic stuff which annoyed me while I was poking at it...
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
>
> diff --git a/drivers/char/tty_ioctl.c b/drivers/char/tty_ioctl.c
> index fd471cb..79e9c17 100644
> --- a/drivers/char/tty_ioctl.c
> +++ b/drivers/char/tty_ioctl.c
> @@ -276,8 +276,8 @@ void tty_termios_encode_baud_rate(struct ktermios *termios, speed_t ibaud, speed
> termios->c_cflag |= (baud_bits[i] << IBSHIFT);
> ifound = i;
> }
> - }
> - while(++i < n_baud_table);
> + } while(++i < n_baud_table);
> +
> if (ofound == -1)
> termios->c_cflag |= BOTHER;
> /* Set exact input bits only if the input and output differ or the
I think, you use old version of tty_ioctl.c :)
http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm1/broken-out/char-tty_ioctl-little-whitespace-cleanup.patch
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
next prev parent reply other threads:[~2007-06-06 13:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 16:27 [PATCH] ARM/ARM26: Enable arbitary speed tty ioctls and split input/output speed Alan Cox
2007-05-23 16:27 ` Russell King
2007-05-24 13:08 ` [PATCH] $ARCH: " David Woodhouse
2007-05-24 13:41 ` Alan Cox
2007-05-24 13:45 ` David Woodhouse
2007-05-24 15:05 ` Alan Cox
2007-05-24 15:18 ` David Woodhouse
2007-05-28 4:47 ` Paul Mackerras
2007-06-06 12:33 ` David Woodhouse
2007-06-08 11:18 ` [PATCH] PowerPC: " David Woodhouse
2007-06-06 12:30 ` [SERIAL] Don't optimise away baud rate changes when BOTHER is used David Woodhouse
2007-06-06 15:03 ` Alan Cox
2007-06-06 17:29 ` David Woodhouse
2007-06-07 15:38 ` Alan Cox
2007-06-07 15:50 ` David Woodhouse
2007-06-07 21:55 ` Alan Cox
2007-06-07 22:04 ` David Woodhouse
2007-06-07 22:15 ` David Woodhouse
2007-06-07 22:54 ` Alan Cox
2007-06-08 11:01 ` David Woodhouse
2007-06-08 11:48 ` Alan Cox
2007-06-08 11:48 ` David Woodhouse
2007-06-08 11:13 ` David Woodhouse
2007-06-08 11:14 ` [SERIAL] Don't optimise away baud rate changes when BOTHER is used (v2) David Woodhouse
2007-06-08 11:42 ` Alan Cox
2007-06-06 12:34 ` [PATCH] Minor cleanups in tty_ioctl.c David Woodhouse
2007-06-06 13:09 ` Jiri Slaby [this message]
2007-05-28 19:36 ` [PATCH] ARM/ARM26: Enable arbitary speed tty ioctls and split input/output speed Russell King
2007-05-28 21:56 ` Andrew Morton
2007-05-28 22:00 ` Russell King
2007-05-29 8:31 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4666B21F.60508@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox