Re: [PATCH] update checkpatch.pl to version 0.03

Andy Whitcroft
2007-06-04T16:51:28Z

jschopp wrote:
>> This version brings a host of changes to cure false positives and
>> bugs detected on patches submitted to lkml and -mm. It also brings
>> a number of new tests in response to reviews, of particular note:
>>
>> - catch use of volatile
>> - allow deprecated functions to be listed in
>> feature-removal-schedule.txt
>> - warn about #ifdef's in c files
>
>
> I think the design philosophy of the style checker should be to err on
> the side of being quiet. It shouldn't report things that aren't
> problems. There are plenty of valid uses of #ifdefs in c files.
> #ifdefs may be abused often. If we start bothering every author that
> uses #ifdefs with an annoying note it detracts from the usefulness of
> our tool.
>
> If we really want to complain about #ifdefs we should add a flag to the
> script so it isn't a default. -potential or something. We could put
> all the "this often is an error" type warnings under it.

The original suggestion was to count them and only complain if there
were "lots". I had thought though that the general consensus was that
#ifdef in C files was pretty much frowned upon. I must admit to working
to the "you must be able to justify all winges in the output" rather
than expecting the result to be empty necessarily.

I am ambivalent on what gets reported as long as its generally useful.
I as you say don't want to produce so much noise that it hides the
useful output.

We've not talked about how the tool might grow. My thought was that
soon we would enable the robot replies on linux-mm (say) and use the
feedback from that to tune what we do and do not report. I have been
pushing all of the contributions to -mm for sometime through it and
cirtainly the #ifdef one once of the more common ones (other than white
space dammage and >80 character lines).

-apw