From: "H. Peter Anvin" <hpa@zytor.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Alistair John Strachan <s0348365@sms.ed.ac.uk>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@osdl.org, linux-kernel@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH] intel-rng: Undo mess made by an 80 column extremist
Date: Thu, 07 Jun 2007 18:08:32 -0700 [thread overview]
Message-ID: <4668AC10.9060305@zytor.com> (raw)
In-Reply-To: <m3sl93zagi.fsf@maximus.localdomain>
Krzysztof Halasa wrote:
> Alistair John Strachan <s0348365@sms.ed.ac.uk> writes:
>
>> I personally buy the argument that 80 cols helps remind people that they've
>> used too many indentation depths and should redesign their code.
>> I think it's
>> a good thing to stick to where possible, even if just from a design
>> perspective.
>
> How many is too many? A function with 2 "if" means 3 tabs = 24 characters
> for just indentation. Add a printk(KERN_DEBUG "\n"); and you can print
> ca. 30 characters without having to break the string. This is crazy.
>
My big concern with the 80-column rule is that it discourages commenting.
-hpa
next prev parent reply other threads:[~2007-06-08 1:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 15:22 [PATCH] intel-rng: Undo mess made by an 80 column extremist Alan Cox
2007-06-07 15:23 ` Jeff Garzik
2007-06-07 15:44 ` Alan Cox
2007-06-07 17:22 ` Jeff Garzik
2007-06-07 21:17 ` Krzysztof Halasa
2007-06-07 21:32 ` Alistair John Strachan
2007-06-07 22:06 ` Krzysztof Halasa
2007-06-08 1:08 ` H. Peter Anvin [this message]
2007-06-08 1:25 ` Jeff Garzik
2007-06-08 10:11 ` Peter Zijlstra
2007-06-09 20:33 ` Krzysztof Halasa
2007-06-07 22:32 ` Daniel Hazelton
2007-06-07 22:37 ` Krzysztof Halasa
2007-06-07 23:01 ` Daniel Hazelton
2007-06-07 22:46 ` Jesper Juhl
2007-06-07 23:04 ` Daniel Hazelton
2007-06-08 1:44 ` John Stoffel
2007-06-08 1:47 ` Jeff Garzik
2007-06-08 1:56 ` John Stoffel
2007-06-08 2:07 ` Jeff Garzik
2007-06-08 2:11 ` John Stoffel
2007-06-08 18:21 ` Ingo Oeser
2007-06-09 20:41 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4668AC10.9060305@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=s0348365@sms.ed.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox