Re: [linux-usb-devel] 2.6.22-rc4-mm1

Greg KH
2007-06-08T18:53:01Z

On Fri, Jun 08, 2007 at 10:06:21AM -0400, Alan Stern wrote:
> On Thu, 7 Jun 2007, Greg KH wrote:
>
> > On Thu, Jun 07, 2007 at 10:53:29AM -0400, Alan Stern wrote:
> > > To tell you the truth, I rather think there's not much point in keeping
> > > usb-try-to-debug-bug-8561.patch around. Anything seriously wrong that
> > > it could catch ought to have shown up long ago. And it is now clear
> > > that bug 8561 has nothing to do with this; it is a programming error
> > > common to many of the USB serial drivers. (Still waiting to hear back
> > > from Paulo Pereira whether the fix to the USB Option driver works...)
> >
> > What error in the usb-serial drivers are you speaking about?
>
> The one addressed by usb-option-fix-usage-of-urb-status-abuse.patch. I
> thought it might be worthwhile to spend some time fixing all of these.
> Here's a quick summary showing the extent of the problem (note that
> not all the usages are in error):

Ah, yeah, I cleaned up a lot of them a while ago, but they keep creaping
back.

I _really_ think we need to just get rid of that field and pass the
status in the urb callback. That would fix this problem once and for
all.

But, from what I remember, the uhci host controller didn't make it easy
for me to acomplish this. Or it might have been another host
controller, can't remember anymore...

So, anyone looking to make up some patches that touch every USB driver
in the tree? I'd be glad to take them :)

thanks,

greg k-h