Re: 2.6.22-rc4-mm1

WANG Cong
2007-06-07T16:38:48Z

On Thu, Jun 07, 2007 at 10:59:14AM -0500, Matt Mackall wrote:
>On Thu, Jun 07, 2007 at 11:40:08PM +0800, WANG Cong wrote:
>> On Thu, Jun 07, 2007 at 09:04:44AM -0500, Matt Mackall wrote:
>> >On Thu, Jun 07, 2007 at 02:51:58PM +0800, WANG Cong wrote:
>> >> >> Maybe there's something wrong with ketchup. ;(
>> >> >
>> >> >Can you do an 'lsdiff | grep lguest' on the patch in your ~/.ketchup directory?
>> >> >
>> >> >Ketchup simply applies patches, it never touches filenames directly.
>> >> >So for something to go wrong here and drop a file in the tree with a
>> >> >damaged pathname, you've either got a damaged patch, a bug in patch
>> >> >itself, or some form of filesystem corruption.
>> >>
>> >> Thanks for your point.
>> >>
>> >> It should be Documentation/lguest/lguest.c, maybe it was corrupted and ketchup
>> >> backuped it as mlguest.c.
>> >
>> >It'd be interesting to figure out how that happened, still.
>> >
>> >If your patch file is intact (are you using GPG's signature-checking
>> >support?), the most likely explanation is an operating system or
>> >filesystem bug.
>>
>> Yes, I am using GPG's checking.
>
>Well that gives a pretty solid assurance that the patch you downloaded
>matches the one on kernel.org. And that one doesn't contain an
>mlguest.c.
>

I agree.

>Ketchup doesn't even look inside patches, and patch doesn't invent
>names, so something in the bzip2 -> patch(1) -> filesystem chain got
>corrupted. Probably not bzip2, as it has CRCs.
>

Do you mean ketchup doesn't do anything if a file is corrupted?

>Do you have ECC memory?
>

No. Do you mean it's an error of my RAM? I have never met such things before,
how often does such kind of things happen? May be less often than a bug in
a stable kernel?

Thanks!