Re: [PATCH] update checkpatch.pl to version 0.03

Andy Whitcroft
2007-06-04T19:08:26Z

Andrew Morton wrote:
> On Mon, 04 Jun 2007 10:46:24 +0100
> Andy Whitcroft <apw@shadowen.org> wrote:
>
>> This version brings a host of changes to cure false positives and
>> bugs detected on patches submitted to lkml and -mm. It also brings
>> a number of new tests in response to reviews, of particular note:
>>
>> - catch use of volatile
>> - allow deprecated functions to be listed in feature-removal-schedule.txt
>> - warn about #ifdef's in c files
>> - check that spinlock_t and struct mutex use is commented
>> - report on architecture specific defines being used
>> - report memory barriers without an associated comment
>
> Oy. I ran checkpatch.pl across this patch and it failed to report upon the
> new trailing whitespace which you just tried to add.

Herm, I guess thats cause its a .pl and therefore exempt from most of
the checks.

I guess line length and white space checks make sense some degree on
those files. I'll sort that out and I guess we'll have anohter version.
Sounds like the #ifdef checks are too much anyhow.

-apw