From: Martin Peschke <mp3@de.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Bill Huey (hui)" <billh@gnuppy.monkey.org>,
linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
jbaron@redhat.com, rostedt@goodmis.org,
linux-s390@vger.kernel.org
Subject: Re: [RFC] [Patch 4/4] lock contention tracking slimmed down
Date: Fri, 08 Jun 2007 18:27:04 +0200 [thread overview]
Message-ID: <46698358.2030407@de.ibm.com> (raw)
In-Reply-To: <20070607073021.GA21139@elte.hu>
Ingo Molnar wrote:
> Firstly, submit cleanup patches that _do not change the output_. If you
> have any output changes, do it as a separate patch, ontop of the cleanup
> patch. Mixing material changes and cleanups into a single patch is a
> basic patch submission mistake that will only earn you NACKs.
Let's put this straight: it has not been my primary goal to clean it up.
I have posted an alternative implementation. One of the good things about the
alternative implementation is lines-of-savings through code sharing.
Don't hear me say my code is perfect. As anybody else here I am relying on
reviews and feedback in order to make it good enough.
I think there has been enough duplication to consider a component
that statistics data is handed over to.
Martin
next prev parent reply other threads:[~2007-06-08 16:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 21:34 [RFC] [Patch 4/4] lock contention tracking slimmed down Martin Peschke
2007-06-06 23:06 ` Ingo Molnar
2007-06-07 0:17 ` Martin Peschke
2007-06-07 4:40 ` Bill Huey
2007-06-07 7:03 ` Martin Peschke
2007-06-07 7:30 ` Ingo Molnar
2007-06-07 8:56 ` Bill Huey
2007-06-11 11:26 ` Martin Peschke
2007-06-08 16:27 ` Martin Peschke [this message]
2007-06-07 6:39 ` Peter Zijlstra
2007-06-07 6:59 ` Martin Peschke
2007-06-07 7:27 ` Ingo Molnar
2007-06-08 16:07 ` Martin Peschke
2007-06-06 23:10 ` Ingo Molnar
2007-06-07 0:21 ` Martin Peschke
2007-06-07 7:44 ` Peter Zijlstra
2007-06-08 17:00 ` Martin Peschke
[not found] ` <1181322460.5728.2.camel@lappy>
[not found] ` <46698F7F.4090407@de.ibm.com>
2007-06-08 17:27 ` Peter Zijlstra
2007-06-08 17:37 ` Martin Peschke
2007-06-08 17:50 ` Peter Zijlstra
2007-06-11 10:31 ` Martin Peschke
2007-06-07 7:51 ` Peter Zijlstra
2007-06-08 17:13 ` Martin Peschke
2007-06-07 8:17 ` Peter Zijlstra
2007-06-07 10:21 ` Ingo Molnar
2007-06-11 12:20 ` Martin Peschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46698358.2030407@de.ibm.com \
--to=mp3@de.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=billh@gnuppy.monkey.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox