From: Joel Schopp <jschopp@austin.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: apw@shadowen.org, rdunlap@xenotime.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: add an exclusion for 'for_each' helper macros
Date: Fri, 08 Jun 2007 12:46:03 -0500 [thread overview]
Message-ID: <466995DB.6080703@austin.ibm.com> (raw)
In-Reply-To: <20070608171105.7391.40550.stgit@dwillia2-linux.ch.intel.com>
Dan Williams wrote:
> checkpatch currently complains about macros like the following:
>
> #define for_each_dma_cap_mask(cap, mask) \
> for ((cap) = first_dma_cap(mask); \
> (cap) < DMA_TX_TYPE_END; \
> (cap) = next_dma_cap((cap), (mask)))
>
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
I'd like it if this patch updated Chapter 12 of Documentation/CodingStyle as well.
That section is where the rule to check came from and it would be nice for it to
mention the exception to the rule as well.
next prev parent reply other threads:[~2007-06-08 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 17:11 [PATCH] checkpatch: add an exclusion for 'for_each' helper macros Dan Williams
2007-06-08 17:46 ` Joel Schopp [this message]
2007-06-09 14:06 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466995DB.6080703@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=apw@shadowen.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox