From: James Ketrenos <jketreno@linux.intel.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@osdl.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.04
Date: Fri, 08 Jun 2007 15:34:55 -0700 [thread overview]
Message-ID: <4669D98F.4090602@linux.intel.com> (raw)
In-Reply-To: <1219bf1ec9ab0dcecc345f9fc3b0f912@pinky>
Andy Whitcroft wrote:
> This version brings a some new tests, and a host of changes to fix
> false positives, of particular note:
>
> - check for and report #if 0
> - extend checking of line lengths and spacing for .pl, .sh etc
> - extends the pointer type checks to multiple levels
> - updates printk handling to track newlines
> - adds a wrapped patch detector
> - drops the leading component of the filenames
> - extends switch indent handling to switch statmentes rooted in
> the context
> - adds foo * bar single pointer checks
I just wanted to say Thank You for putting checkpatch.pl together.
I've only used v0.1 here (its what showed up in wireless-dev) but
it made pruning through the iwlwifi sources to clean things up a
very manageable task.
Great job so far.
Thanks,
James
prev parent reply other threads:[~2007-06-09 0:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 9:41 [PATCH] update checkpatch.pl to version 0.04 Andy Whitcroft
2007-06-08 22:34 ` James Ketrenos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4669D98F.4090602@linux.intel.com \
--to=jketreno@linux.intel.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox