From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759500AbXFJCmR (ORCPT ); Sat, 9 Jun 2007 22:42:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754544AbXFJCmI (ORCPT ); Sat, 9 Jun 2007 22:42:08 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:35831 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753666AbXFJCmH (ORCPT ); Sat, 9 Jun 2007 22:42:07 -0400 Message-ID: <466B64FC.1090509@garzik.org> Date: Sat, 09 Jun 2007 22:42:04 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Olof Johansson CC: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH] [2.6.22] libata: fix probe time irq printouts References: <20070603233510.GA25750@lixom.net> In-Reply-To: <20070603233510.GA25750@lixom.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.8 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Olof Johansson wrote: > Most drivers don't seem to fill out the host->irq field, resulting in the > wrong (no) irq being reported at probe time. For example, sil24 on my system: > > ata1: SATA max UDMA/100 cmd 0xd00008009001f000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0 > ata2: SATA max UDMA/100 cmd 0xd000080090021000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0 > > Since they're allocated and set up in ata_host_activate(), just save > them away there. > > > Signed-off-by: Olof Johansson > > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index af62514..7491b11 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -6438,6 +6438,9 @@ int ata_host_activate(struct ata_host *host, int irq, > if (rc) > devm_free_irq(host->dev, irq, host); > > + /* Used to print device info at probe */ > + host->irq = irq; > + applied, thanks for fixing that