Re: [PATCH] ahci: Add MCP73/MCP77 support to AHCI driver

Re: [PATCH] ahci: Add MCP73/MCP77 support to AHCI driver

[Tejun Heo]

Peer Chen wrote:
> Add the MCP73/MCP77 support to ahci driver.
> The patch base on kernel 2.6.22-rc4

Please resend in plain text.  My recommendations...

1. If you can setup a linux machine with working MTA, use
git-format-patch and git-send-email.  If you don't feel comfortable with
git, you can use mutt + your favorite editor (I use emacs).

2. Use firefox + external editor plugin with line-wrap turned off.

Thanks.

-- 
tejun

[PATCH] ahci: Add MCP73/MCP77 support to AHCI driver

[Peer Chen]

Add the MCP73/MCP77 support to ahci driver.
The patch base on kernel 2.6.22-rc4
 
Signed-off-by: Peer Chen <peerchen@gmail.com>
------------------------------------------------
--- linux-2.6.22-rc4/drivers/ata/ahci.c.orig
+++ linux-2.6.22-rc4/drivers/ata/ahci.c
@@ -426,6 +426,30 @@ static const struct pci_device_id ahci_p
 	{ PCI_VDEVICE(NVIDIA, 0x0559), board_ahci },		/* MCP67 */
 	{ PCI_VDEVICE(NVIDIA, 0x055a), board_ahci },		/* MCP67 */
 	{ PCI_VDEVICE(NVIDIA, 0x055b), board_ahci },		/* MCP67 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f0), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f1), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f2), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f3), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f4), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f5), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f6), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f7), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f8), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07f9), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07fa), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x07fb), board_ahci },		/* MCP73 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad0), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad1), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad2), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad3), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad4), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad5), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad6), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad7), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad8), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ad9), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0ada), board_ahci },		/* MCP77 */
+	{ PCI_VDEVICE(NVIDIA, 0x0adb), board_ahci },		/* MCP77 */
 
 	/* SiS */
 	{ PCI_VDEVICE(SI, 0x1184), board_ahci }, /* SiS 966 */

Re: [PATCH] ahci: Add MCP73/MCP77 support to AHCI driver

[Tejun Heo]

Hello,

This one looks much better.  Just few more things.

Peer Chen wrote:
> Add the MCP73/MCP77 support to ahci driver.
> The patch base on kernel 2.6.22-rc4
>  
> Signed-off-by: Peer Chen <peerchen@gmail.com>
> ------------------------------------------------

The separator is '---'.  Automated tools are used, so sticking to it
makes things easier.

> --- linux-2.6.22-rc4/drivers/ata/ahci.c.orig
> +++ linux-2.6.22-rc4/drivers/ata/ahci.c
> @@ -426,6 +426,30 @@ static const struct pci_device_id ahci_p
>  	{ PCI_VDEVICE(NVIDIA, 0x0559), board_ahci },		/* MCP67 */
>  	{ PCI_VDEVICE(NVIDIA, 0x055a), board_ahci },		/* MCP67 */
>  	{ PCI_VDEVICE(NVIDIA, 0x055b), board_ahci },		/* MCP67 */
> +	{ PCI_VDEVICE(NVIDIA, 0x07f0), board_ahci },		/* MCP73 */
> +	{ PCI_VDEVICE(NVIDIA, 0x07f1), board_ahci },		/* MCP73 */
[--snip--]

Whoa, that's a lot of PCI IDs.  AHCI PCI class code doesn't catch them?

-- 
tejun

Re: [PATCH] ahci: Add MCP73/MCP77 support to AHCI driver

[Jeff Garzik]

Peer Chen wrote:
> Add the MCP73/MCP77 support to ahci driver.
> The patch base on kernel 2.6.22-rc4
>  
> Signed-off-by: Peer Chen <peerchen@gmail.com>

applied

Please put comments that should not be copied into the permanent kernel 
changelog following a "---" separator, as described in 
Documentation/SubmittingPatches.  The sentence "The patch base on kernel 
2.6.22-rc4" had to be hand-edited out, before automatic patch merge 
scripts merged your patch.