From: Avi Kivity <avi@qumranet.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: "Li, Xin B" <xin.b.li@intel.com>,
kvm-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration
Date: Sun, 10 Jun 2007 10:36:01 +0300 [thread overview]
Message-ID: <466BA9E1.6040909@qumranet.com> (raw)
In-Reply-To: <20070608194441.GA8169@c2.user-mode-linux.org>
Jeff Dike wrote:
> On Thu, Jun 07, 2007 at 08:09:48AM +0300, Avi Kivity wrote:
>
>> Some extra logic is needed on i386 with >= 4GB. Current code will
>> wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not
>> the answer since the processor will truncate it back to 32 bits (the
>> return value is eventually used as a long in enter_rmode()).
>>
>
> Is it necessary to initialize TR in enter_rmode? I can't see anything
> that says it has any meaning in real mode.
>
>
VT doesn't support real mode. kvm uses virtual-8086 mode to virtualize
real mode. Virtual 8086 mode does require a task state segment.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2007-06-10 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 19:19 [PATCH] KVM - Fix rmode_tss_base declaration Jeff Dike
2007-06-07 2:13 ` [kvm-devel] " Li, Xin B
2007-06-07 3:11 ` Jeff Dike
2007-06-07 5:09 ` Avi Kivity
2007-06-08 19:44 ` Jeff Dike
2007-06-10 7:36 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466BA9E1.6040909@qumranet.com \
--to=avi@qumranet.com \
--cc=jdike@addtoit.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=xin.b.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox