Re: [PATCH] pata_it821x: (partially) fix DMA in RAID mode

Jeff Garzik
2007-06-11T04:52:35Z

Bartlomiej Zolnierkiewicz wrote:
> Code intended to check DMA status was checking DMA command register.
>
> Moreover firmware seems to "forget" to set DMA capable bit for the
> slave device (at least in RAID mode but without ITE RAID volumes) so
> check device ID for DMA capable bit when deciding whether to use DMA
> and remove DMA status check completely.
>
> Thanks to Pavol Šimo for the bugreport and testing the initial fix.
>
> This change unfortunately still doesn't fix DMA in RAID mode (which
> works fine with IDE it821x) but Alan is working on the missing pieces
> (pata_it821x vs libata EH issues).
>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Cc: Tejun Heo <htejun@gmail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
>
> drivers/ata/pata_it821x.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)

Patch is OK but it's mangled by your mailer:

@@ -79,7 +80,7 @@
=20
=20
#define DRV_NAME "pata_it821x"
=2D#define DRV_VERSION "0.3.6"
+#define DRV_VERSION "0.3.7"
=20
struct it821x_dev
{
@@ -460,14 +461,8 @@ static unsigned int it821x_passthru_qc_i
=20

=2D int dma_enabled =3D 0;
int i;
=20

etc.