public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Jan Kara <jack@suse.cz>
Cc: Chuck Ebbert <cebbert@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Stephen Tweedie <sct@redhat.com>, "Theodore Ts'o" <tytso@mit.edu>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: ext3fs: umount+sync not enough to guarantee metadata-on-disk
Date: Mon, 11 Jun 2007 18:46:09 -0400	[thread overview]
Message-ID: <466DD0B1.7020802@rtr.ca> (raw)
In-Reply-To: <20070611110547.GA26561@atrey.karlin.mff.cuni.cz>

Jan Kara wrote:
>> Chuck Ebbert wrote:
>>> On 06/07/2007 11:41 AM, Andrew Morton wrote:
>>>>>   mount /var/lib/mythtv -oremount,ro
>>>>>   sync
>>>>>   umount /var/lib/mythtv
>>>> Did this succeed?  If the application is still truncating that file, the
>>>> umount should have failed.
>>> Shouldn't sync should wait for truncate to finish?
>> The part that gets me here, and that others might be missing,
>> is that we are not waiting for ftruncate at this point.
>>
>> We're waiting for unlink.  The application that was doing ftruncate
>> in tiny little doses has been sent a kill-9 signal, so what should
>> be happening now (confirmed by disk activity LEDs) is the file should
>> just be getting deleted the same as if we did "rm bigfile" on it.
>   But if that app has been waiting in D state, kill -9 does nothing to it
> until it wakes up, doesn't it? So fd's are still open and umount fails.

Yeah, except the task is in Zombie state at this point.
But the umount does fail properly, so I no longer complain about that.

Cheers

      reply	other threads:[~2007-06-11 22:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-07 13:44 ext3fs: umount+sync not enough to guarantee metadata-on-disk Mark Lord
2007-06-07 15:41 ` Andrew Morton
2007-06-07 16:01   ` Mark Lord
2007-06-07 17:09     ` Stephen C. Tweedie
2007-06-10 18:27     ` Pavel Machek
2007-06-12 15:15       ` Stephen C. Tweedie
2007-06-14 19:01       ` Phillip Susi
2007-06-07 16:11   ` Chuck Ebbert
2007-06-07 19:45     ` Andrew Morton
2007-06-07 21:38       ` Mark Lord
2007-06-07 22:04         ` Andrew Morton
2007-06-08 14:51           ` Mark Lord
2007-06-09  2:58       ` Mark Lord
2007-06-11 11:14         ` Jan Kara
2007-06-11 22:47           ` Mark Lord
2007-06-12 10:00             ` Jan Kara
2007-06-07 21:43     ` Mark Lord
2007-06-10 18:31       ` Pavel Machek
2007-06-11 11:05       ` Jan Kara
2007-06-11 22:46         ` Mark Lord [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=466DD0B1.7020802@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=akpm@linux-foundation.org \
    --cc=cebbert@redhat.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox