From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: libata passthru: support PIO multi commands
Date: Mon, 11 Jun 2007 20:09:28 -0400 [thread overview]
Message-ID: <466DE438.70108@garzik.org> (raw)
In-Reply-To: <20070611233917.4bd8c6d7@the-village.bc.nu>
Alan Cox wrote:
>> + if (is_multi_taskfile(tf)) {
>> + unsigned int multi_count = 1 << (cdb[1] >> 5);
>> +
>> + /* compare the passed through multi_count
>> + * with the cached multi_count of libata
>> + */
>> + if (multi_count != dev->multi_count)
>> + ata_dev_printk(dev, KERN_WARNING,
>> + "invalid multi_count %u ignored\n",
>> + multi_count);
>> + }
>
> What limits log spamming here ?
Intelligence of the user with privs?
> Also shouldn't we error this
> situation not proceed and hope that enough data was supplied not
> to leave us stuck half way through a command having made a nasty
> mess on disk ?
Is that English? Can you be more specific and more clear?
Jeff
next prev parent reply other threads:[~2007-06-12 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200706112200.l5BM0qFn005767@hera.kernel.org>
2007-06-11 22:39 ` libata passthru: support PIO multi commands Alan Cox
2007-06-12 0:09 ` Jeff Garzik [this message]
2007-06-12 10:16 ` Alan Cox
2007-06-12 15:18 ` Jeff Garzik
2007-06-12 16:05 ` Alan Cox
2007-06-13 2:57 ` Albert Lee
2007-06-13 18:40 ` Mark Lord
2007-06-13 18:55 ` Sergei Shtylyov
2007-06-13 18:55 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466DE438.70108@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox