public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@kernel.org>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, dipankar@in.ibm.com,
	akpm@linux-foundation.org
Subject: Re: [PATCH] Force rcutorture tasks to spread over CPUs
Date: Wed, 13 Jun 2007 09:49:36 -0700	[thread overview]
Message-ID: <46702020.7090802@kernel.org> (raw)
In-Reply-To: <20070613042804.GA6132@linux.vnet.ibm.com>

Paul E. McKenney wrote:
> Of late, the scheduler seems to have decided to make things too easy for
> RCU -- on some configurations, all of the rcutorture tasks end up on the
> same CPU, which doesn't do a very good job of torturing RCU.  This patch
> helps the scheduler spread these tasks out by forcing a 20-millisecond
> burst of CPU-bound execution on each of rcutorture's tasks, which seems
> to work reasonably well in practice.

Given the scheduler behavior you observed, this seems reasonable to me, and it
seems reasonable to do this balancing by default.  You might consider adding a
module param to set the timeout, and disable the barrier code entirely when 0,
so people can still test the previous behavior.

Independently from this change, you might also consider adding a way to set
CPU affinity for rcutorture threads.  This would allow explicitly spreading
readers and writers across all CPUs, and possibly also allow clumping these
threads together on CPUs in bug-revealing ways.

> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Acked-by: Josh Triplett <josh@kernel.org>

- Josh Triplett

  reply	other threads:[~2007-06-13 16:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13  4:28 [PATCH] Force rcutorture tasks to spread over CPUs Paul E. McKenney
2007-06-13 16:49 ` Josh Triplett [this message]
2007-06-26 23:13 ` Andrew Morton
2007-06-27  6:30   ` Ingo Molnar
2007-06-27 16:30     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46702020.7090802@kernel.org \
    --to=josh@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dipankar@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox