public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: bryan.wu@analog.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Blackfin updates for 2.6.22-rc4
Date: Wed, 13 Jun 2007 22:57:37 -0400	[thread overview]
Message-ID: <4670AEA1.8030409@garzik.org> (raw)
In-Reply-To: <1181786785.21995.5.camel@roc-desktop>

Bryan Wu wrote:
> Hi Linus:
> 
> Sorry for word-wrapping in previous git pull request email.
>  
> please pull from:
> 
>   master.kernel.org:/pub/scm/linux/kernel/git/cooloney/blackfin-2.6.git master

You should run your patch through scripts/checkpatch.pl before 
pushing... there are several notables in there like tons of trailing 
whitespace, use of spaces rather than tabs, lack of whitespace inside 
expressions, etc.

The "line over 80 chars" warning can get a bit obnoxious, if you are 
barely over the limit, but the other warnings are pretty reasonable.



  parent reply	other threads:[~2007-06-14  2:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-14  2:06 [GIT PULL] Blackfin updates for 2.6.22-rc4 Bryan Wu
2007-06-14  2:36 ` Paul Mundt
2007-06-14  2:57 ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-06-14  7:09 Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4670AEA1.8030409@garzik.org \
    --to=jeff@garzik.org \
    --cc=bryan.wu@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox