From: Avi Kivity <avi@qumranet.com>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [BUG] Oops with KVM-27
Date: Thu, 14 Jun 2007 11:26:29 +0300 [thread overview]
Message-ID: <4670FBB5.70707@qumranet.com> (raw)
In-Reply-To: <20070613204948.GA14710@dreamland.darkstar.lan>
Luca Tettamanti wrote:
> With GOOD_APIC apic_read_around is a nop, while apic_write_around is a
> normal write. With !GOOD_APIC apic_write_around writes to the APIC reg
> using xchg. With !GOOD_APIC and this patch:
>
> --- include/asm-i386/apic.h~ 2007-04-26 05:08:32.000000000 +0200
> +++ include/asm-i386/apic.h 2007-06-13 22:35:00.000000000 +0200
> @@ -56,7 +56,8 @@
> static __inline fastcall void native_apic_write_atomic(unsigned long reg,
> unsigned long v)
> {
> - xchg((volatile unsigned long *)(APIC_BASE+reg), v);
> +// xchg((volatile unsigned long *)(APIC_BASE+reg), v);
> + *((volatile unsigned long *)(APIC_BASE+reg)) = v;
> }
>
> static __inline fastcall unsigned long native_apic_read(unsigned long reg)
>
> The kernel boots fine.
>
Looking at the xchg emulation code, it seems fine, but clearly it
isn't. Can you add logging to the kernel apic driver and to the qemu
device emulation (qemu/hw/apic.c, apic_mem_readl()/apic_mem_writel())
and compare the results?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2007-06-14 8:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 21:34 [BUG] Oops with KVM-27 Luca Tettamanti
2007-06-04 9:35 ` [kvm-devel] " Avi Kivity
2007-06-04 20:22 ` Luca Tettamanti
2007-06-04 20:51 ` Avi Kivity
2007-06-04 21:22 ` Luca Tettamanti
2007-06-05 7:27 ` Avi Kivity
2007-06-07 19:16 ` Luca
2007-06-10 12:22 ` Avi Kivity
2007-06-10 20:54 ` Luca
2007-06-11 7:44 ` Avi Kivity
2007-06-11 21:06 ` Luca
2007-06-12 6:44 ` Avi Kivity
2007-06-12 17:52 ` Luca Tettamanti
2007-06-13 8:59 ` Avi Kivity
2007-06-13 20:49 ` Luca Tettamanti
2007-06-14 8:26 ` Avi Kivity [this message]
2007-06-14 22:33 ` Luca Tettamanti
2007-06-14 22:53 ` Luca Tettamanti
2007-06-14 23:13 ` Luca Tettamanti
2007-06-14 23:27 ` Luca
2007-06-15 9:06 ` Avi Kivity
2007-06-15 21:49 ` Luca Tettamanti
2007-06-16 7:43 ` Avi Kivity
2007-06-17 15:14 ` Luca Tettamanti
2007-06-17 15:24 ` Avi Kivity
2007-06-17 16:52 ` [PATCH 1/2] kvm: Fix x86 emulator writeback Luca Tettamanti
2007-06-17 16:58 ` Avi Kivity
2007-06-18 10:07 ` Avi Kivity
2007-06-18 11:32 ` Avi Kivity
2007-06-19 20:25 ` Luca Tettamanti
2007-06-19 20:41 ` Luca Tettamanti
2007-06-20 7:47 ` Avi Kivity
2007-06-19 20:41 ` [PATCH 2/2] kvm: avoid useless memory write when possible Luca Tettamanti
2007-06-17 16:52 ` Luca Tettamanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4670FBB5.70707@qumranet.com \
--to=avi@qumranet.com \
--cc=kronos.it@gmail.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).