From: Paul Clements <paul.clements@steeleye.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Pavel Machek <pavel@ucw.cz>, Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nbd.c:sock_xmit: cleanup signal related code
Date: Thu, 14 Jun 2007 15:36:40 -0400 [thread overview]
Message-ID: <467198C8.1040107@steeleye.com> (raw)
In-Reply-To: <20070614172243.GA2446@tv-sign.ru>
Oleg Nesterov wrote:
> sock_xmit() re-implements sigprocmask() and dequeue_signal_lock().
Yeah, that code was written before those existed. Thanks for the clean up.
> Note: I can't understand this dequeue_signal(), it can dequeue SIGKILL
> for the user-space task doing nbd_ioctl() ?
So we can interrupt an nbd transmission without waiting for a TCP
timeout (when we know the network is down).
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Patch looks good to me.
--
Paul
next prev parent reply other threads:[~2007-06-14 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 17:22 [PATCH] nbd.c:sock_xmit: cleanup signal related code Oleg Nesterov
2007-06-14 19:36 ` Paul Clements [this message]
2007-06-14 20:11 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467198C8.1040107@steeleye.com \
--to=paul.clements@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=pavel@ucw.cz \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox