From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F0B213790B for ; Tue, 23 Jun 2026 02:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782181273; cv=none; b=QrIOWjMzj2rIXL2P5ijse0LUwxpSkXTdxRJdte1EKKjUdcw6mqa3LmEOpgJXVWRD3cbnfzEJnY1GKsoQCb2JJug/cV1/7aJQm2Je67qeGEmzmn90E8csIf5XPqME3dPr4yWtSpUsbQN0kg5WyRpkhamY0mmDHws7RHqEurFBZ90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782181273; c=relaxed/simple; bh=Pqzh3hhRMfiP2uRy2M0e846l/Oe1N6KvLm26cT2E7Is=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FhR3jhIVd7W0lAOa1YSE4iw4DnLfKgfnbzE6mLTzgmw1oJ8iBh9FKNi3VjIWY5oUCHIrX5sCoGStGFKxFkieU5qUhiqGiIcn2CuIgfaaUwz0rpNamLqsuLiOFJOjBMiSzEH11efKdpG9i2mhPBcdPsS5S++bAp6JEiH548AMgVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=VUCWDlmG; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="VUCWDlmG" Message-ID: <46730710-fa60-4332-820c-0a68acf00dd4@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782181268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lMffO2o77SuR2hBlttDpYw1QPIJxJT/T6T/rBhU7vx4=; b=VUCWDlmG7W9buVSD5ve7UbTJnBWCcsS3T/Oq+PfLVKKFkVQmc97akdOQDziHich3ufJFtK QaYoQwbOgqjrvYDiTCUImSPEGiC2q3Bc2U2smVp9Z5UCFzARkJS8wC1BapXmpb8mInfnh/ 6Xr+q2+2RYBYhhAh3SxFOtsSz70yPpc= Date: Tue, 23 Jun 2026 10:20:27 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] mm: mglru: fix stale batch updates after memcg reparenting To: Barry Song Cc: akpm@linux-foundation.org, david@kernel.org, kasong@tencent.com, shakeel.butt@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, hannes@cmpxchg.org, harry@kernel.org, muchun.song@linux.dev, peiyang_he@smail.nju.edu.cn, mhocko@kernel.org, roman.gushchin@linux.dev, ljs@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng , stable@vger.kernel.org References: <5A9E929D82717101+12fcf643-efb8-4b9a-a53a-1e28cc894f0b@smail.nju.edu.cn> <20260622073703.79258-1-qi.zheng@linux.dev> <19710ee5-8e1c-4b13-812b-4b03ca34260d@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 6/23/26 10:15 AM, Barry Song wrote: > On Tue, Jun 23, 2026 at 9:58 AM Qi Zheng wrote: >> [...] >>>> >>>> WARNING: mm/vmscan.c:5867 at lru_gen_exit_memcg+0x26f/0x300 >>>> RIP: 0010:lru_gen_exit_memcg+0x26f/0x300 mm/vmscan.c:5867 >>> >>> I can't find 5867; instead, I can find 5828: >>> >>> VM_WARN_ON_ONCE(memchr_inv(lruvec->lrugen.nr_pages, 0, >>> sizeof(lruvec->lrugen.nr_pages))); >>> >>> Is this the warning? >> >> Yes, I just copy-pasted the warning log from Peiyang's report. >> >> Maybe the description should be changed to: >> >> This will trigger the following warning in lru_gen_exit_memcg(): >> >> VM_WARN_ON_ONCE(memchr_inv(lruvec->lrugen.nr_pages, 0, >> sizeof(lruvec->lrugen.nr_pages))); >> >>> > > Yep. Can we update the v2 changelog accordingly? Sure, will do in v2. Thanks, Qi > > Best Regards > Barry