From: Chuck Ebbert <cebbert@redhat.com>
To: Gregory Haskins <ghaskins@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] natsemi irq flags
Date: Fri, 15 Jun 2007 18:06:58 -0400 [thread overview]
Message-ID: <46730D82.7020508@redhat.com> (raw)
In-Reply-To: <20070615211608.11079.35368.stgit@ghaskins-t60p.haskins.net>
On 06/15/2007 05:17 PM, Gregory Haskins wrote:
> The spinlock irq flags should be a unsigned long to properly support 64 bit
Ouch. Can't we automate checking for that?
>
> Signed-off-by: Gregory Haskins <ghaskins@novell.com>
>
> ---
>
> drivers/net/natsemi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
> index 4cf0d3f..460a087 100644
> --- a/drivers/net/natsemi.c
> +++ b/drivers/net/natsemi.c
> @@ -690,7 +690,7 @@ static ssize_t natsemi_set_dspcfg_workaround(struct device *dev,
> {
> struct netdev_private *np = netdev_priv(to_net_dev(dev));
> int new_setting;
> - u32 flags;
> + unsigned long flags;
>
> /* Find out the new setting */
> if (!strncmp("on", buf, count - 1) || !strncmp("1", buf, count - 1))
>
next prev parent reply other threads:[~2007-06-15 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 21:17 [PATCH] natsemi irq flags Gregory Haskins
2007-06-15 22:06 ` Chuck Ebbert [this message]
2007-06-16 2:40 ` Alexey Dobriyan
2007-06-20 23:15 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46730D82.7020508@redhat.com \
--to=cebbert@redhat.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox