From: Jiri Slaby <jirislaby@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] make pci_ids lowercase hexa
Date: Mon, 18 Jun 2007 10:39:10 +0200 [thread overview]
Message-ID: <467644AE.5050008@gmail.com> (raw)
In-Reply-To: <20070617214555.GA305@kroah.com>
Greg KH napsal(a):
> On Sun, Jun 17, 2007 at 09:08:31AM +0200, Jiri Slaby wrote:
>> Greg KH napsal(a):
>>> Why? What good is this going to do in the long run?
>> It's just cleanup to get rid of things like this:
>> #define PCI_DEVICE_ID_PROMISE_20246 0x4d33
>> #define PCI_DEVICE_ID_PROMISE_20262 0x4d38
>> -#define PCI_DEVICE_ID_PROMISE_20263 0x0D38
>> +#define PCI_DEVICE_ID_PROMISE_20263 0x0d38
>> #define PCI_DEVICE_ID_PROMISE_20268 0x4d68
>
> Get rid of what? What's wrong with upper case hex numbers? This seems
> like a pretty gratitous change to me.
Ok.
> Care to resend your other fixes to me, if you still think they are
> needed?
Sure.
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
prev parent reply other threads:[~2007-06-18 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-16 15:44 [PATCH 1/6] make pci_ids lowercase hexa Jiri Slaby
2007-06-16 15:45 ` [PATCH 2/6] pci_ids, remove double or more empty lines Jiri Slaby
2007-06-16 15:46 ` [PATCH 3/6] ATM: lanai, change VENDOR to DEVICE Jiri Slaby
2007-06-16 15:46 ` [PATCH 4/6] i386: traps, " Jiri Slaby
2007-06-16 15:47 ` [PATCH 5/6] pci_ids, reorder some entries Jiri Slaby
2007-06-16 15:48 ` [PATCH 6/6] pci_ids, add atheros and 3com_2 vendors Jiri Slaby
2007-06-16 19:57 ` [PATCH 1/6] make pci_ids lowercase hexa Greg KH
2007-06-17 7:08 ` Jiri Slaby
2007-06-17 21:45 ` Greg KH
2007-06-18 8:39 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467644AE.5050008@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox