From: Randy Dunlap <randy.dunlap@oracle.com>
To: Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] blink: Only blink when parameter is set
Date: Mon, 18 Jun 2007 07:43:46 -0700 [thread overview]
Message-ID: <46769A22.3030908@oracle.com> (raw)
In-Reply-To: <20070618071819.GA9953@suse.de>
Bernhard Walle wrote:
> * Randy Dunlap <randy.dunlap@oracle.com> [2007-06-18 06:26]:
>>> +static int blink = 0;
>> no need to init to 0.
>
> Does it harm?
It adds space to the binary file in some cases and it is kernel
convention not to init statics to NULL or 0 since that is already
guaranteed for them.
>>> +module_param(blink, bool, S_IRUGO);
>>> +MODULE_PARM_DESC(blink, "Enable blinking (without that, the module does nothing)\n");
>> unneeded "\n"
>
> Fixed. Please use the following patch.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-06-18 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-17 8:39 [PATCH] blink: Only blink when parameter is set Bernhard Walle
2007-06-17 16:11 ` Arjan van de Ven
2007-06-18 4:26 ` Randy Dunlap
2007-06-18 7:18 ` Bernhard Walle
2007-06-18 14:43 ` Randy Dunlap [this message]
2007-06-20 20:16 ` Pavel Machek
2007-06-20 23:51 ` Jiri Kosina
2007-06-21 0:20 ` Pavel Machek
2007-06-21 0:24 ` Jiri Kosina
2007-06-21 2:56 ` Dmitry Torokhov
2007-06-22 8:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46769A22.3030908@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox