public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cedric Le Goater <clg@fr.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Herbert Poetzl <herbert@13thfloor.at>,
	pbadari@us.ibm.com, containers@lists.osdl.org,
	ebiederm@xmission.com, serue@us.ibm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] create_new_namespaces: fix improper return of NULL
Date: Tue, 19 Jun 2007 17:41:54 +0200	[thread overview]
Message-ID: <4677F942.6080909@fr.ibm.com> (raw)
In-Reply-To: <20070619142730.GA27361@tv-sign.ru>

Oleg Nesterov wrote:
> On 06/19, Cedric Le Goater wrote:
>> Oleg Nesterov wrote:
>>> Untested.
>>>
>>> dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong,
>>> create_new_namespaces() uses ERR_PTR() to catch an error. This means
>>> that the subsequent create_new_namespaces() will hit BUG_ON() in
>>> copy_mnt_ns() or copy_utsname().
>> I sent one just like it :
>>
>> 	http://lkml.org/lkml/2007/6/12/142
> 
> Ah, thanks.
> 
> Your patch is more complete, it also fixes kernel/user_namespace.c (which
> I don't see in 2.6.22-rc5). I don't this this fix is urgent, so...

This patch applies on top of previous i've sent to andrew. 
kernel/user_namespace.c should be in -mm.

Thanks,

C. 

      reply	other threads:[~2007-06-19 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200705090245.l492jZwD008756@shell0.pdx.osdl.net>
     [not found] ` <20070616191742.GA13434@MAIL.13thfloor.at>
     [not found]   ` <20070617143830.GA379@tv-sign.ru>
     [not found]     ` <20070617163004.GA553@tv-sign.ru>
2007-06-19 13:51       ` [PATCH] create_new_namespaces: fix improper return of NULL Oleg Nesterov
2007-06-19 14:05         ` Cedric Le Goater
2007-06-19 14:27           ` Oleg Nesterov
2007-06-19 15:41             ` Cedric Le Goater [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4677F942.6080909@fr.ibm.com \
    --to=clg@fr.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=herbert@13thfloor.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=pbadari@us.ibm.com \
    --cc=serue@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox