* [PATCH] natsemi irq flags
@ 2007-06-15 21:17 Gregory Haskins
2007-06-15 22:06 ` Chuck Ebbert
2007-06-20 23:15 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Gregory Haskins @ 2007-06-15 21:17 UTC (permalink / raw)
To: linux-kernel
The spinlock irq flags should be a unsigned long to properly support 64 bit
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
drivers/net/natsemi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index 4cf0d3f..460a087 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -690,7 +690,7 @@ static ssize_t natsemi_set_dspcfg_workaround(struct device *dev,
{
struct netdev_private *np = netdev_priv(to_net_dev(dev));
int new_setting;
- u32 flags;
+ unsigned long flags;
/* Find out the new setting */
if (!strncmp("on", buf, count - 1) || !strncmp("1", buf, count - 1))
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] natsemi irq flags
2007-06-15 21:17 [PATCH] natsemi irq flags Gregory Haskins
@ 2007-06-15 22:06 ` Chuck Ebbert
2007-06-16 2:40 ` Alexey Dobriyan
2007-06-20 23:15 ` Jeff Garzik
1 sibling, 1 reply; 4+ messages in thread
From: Chuck Ebbert @ 2007-06-15 22:06 UTC (permalink / raw)
To: Gregory Haskins; +Cc: linux-kernel
On 06/15/2007 05:17 PM, Gregory Haskins wrote:
> The spinlock irq flags should be a unsigned long to properly support 64 bit
Ouch. Can't we automate checking for that?
>
> Signed-off-by: Gregory Haskins <ghaskins@novell.com>
>
> ---
>
> drivers/net/natsemi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
> index 4cf0d3f..460a087 100644
> --- a/drivers/net/natsemi.c
> +++ b/drivers/net/natsemi.c
> @@ -690,7 +690,7 @@ static ssize_t natsemi_set_dspcfg_workaround(struct device *dev,
> {
> struct netdev_private *np = netdev_priv(to_net_dev(dev));
> int new_setting;
> - u32 flags;
> + unsigned long flags;
>
> /* Find out the new setting */
> if (!strncmp("on", buf, count - 1) || !strncmp("1", buf, count - 1))
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] natsemi irq flags
2007-06-15 22:06 ` Chuck Ebbert
@ 2007-06-16 2:40 ` Alexey Dobriyan
0 siblings, 0 replies; 4+ messages in thread
From: Alexey Dobriyan @ 2007-06-16 2:40 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: Gregory Haskins, linux-kernel
On Fri, Jun 15, 2007 at 06:06:58PM -0400, Chuck Ebbert wrote:
> On 06/15/2007 05:17 PM, Gregory Haskins wrote:
> > The spinlock irq flags should be a unsigned long to properly support 64 bit
>
> Ouch. Can't we automate checking for that?
Hopefully I'll do it before next -rc1.
--- a/include/linux/types.h
+++ b/include/linux/types.h
@@ -191,6 +191,7 @@ typedef __u32 __bitwise __wsum;
#ifdef __KERNEL__
typedef unsigned __bitwise__ gfp_t;
+typedef unsigned long __bitwise__ irq_flags_t;
#ifdef CONFIG_RESOURCES_64BIT
typedef u64 resource_size_t;
803 files changed, 2651 insertions(+), 2617 deletions(-)
and counting
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] natsemi irq flags
2007-06-15 21:17 [PATCH] natsemi irq flags Gregory Haskins
2007-06-15 22:06 ` Chuck Ebbert
@ 2007-06-20 23:15 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-06-20 23:15 UTC (permalink / raw)
To: Gregory Haskins; +Cc: linux-kernel
Gregory Haskins wrote:
> The spinlock irq flags should be a unsigned long to properly support 64 bit
>
> Signed-off-by: Gregory Haskins <ghaskins@novell.com>
>
> ---
>
> drivers/net/natsemi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied to #upstream-fixes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-06-20 23:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-15 21:17 [PATCH] natsemi irq flags Gregory Haskins
2007-06-15 22:06 ` Chuck Ebbert
2007-06-16 2:40 ` Alexey Dobriyan
2007-06-20 23:15 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox