From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757857AbXFTX5N (ORCPT ); Wed, 20 Jun 2007 19:57:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756445AbXFTX4z (ORCPT ); Wed, 20 Jun 2007 19:56:55 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:45875 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756954AbXFTX4x (ORCPT ); Wed, 20 Jun 2007 19:56:53 -0400 Message-ID: <4679BEC2.5040007@garzik.org> Date: Wed, 20 Jun 2007 19:56:50 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz CC: Alan Cox , Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_it821x: (partially) fix DMA in RAID mode References: <200706111140.08048.bzolnier@gmail.com> In-Reply-To: <200706111140.08048.bzolnier@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Bartlomiej Zolnierkiewicz wrote: > Code intended to check DMA status was checking DMA command register. > > Moreover firmware seems to "forget" to set DMA capable bit for the > slave device (at least in RAID mode but without ITE RAID volumes) so > check device ID for DMA capable bit when deciding whether to use DMA > and remove DMA status check completely. > > Thanks to Pavol Simo for the bugreport and testing the initial fix. > > This change unfortunately still doesn't fix DMA in RAID mode (which > works fine with IDE it821x) but Alan is working on the missing pieces > (pata_it821x vs libata EH issues). > > Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-by: Alan Cox > Cc: Tejun Heo > --- > removed non-ASCII char from the patch description + added Alan's ACK > > drivers/ata/pata_it821x.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) applied