From: Randy Dunlap <randy.dunlap@oracle.com>
To: Bob Picco <bob.picco@hp.com>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded
Date: Wed, 20 Jun 2007 21:54:12 -0700 [thread overview]
Message-ID: <467A0474.809@oracle.com> (raw)
In-Reply-To: <20070621011422.GF10927@localhost>
Bob Picco wrote:
> Randy Dunlap wrote: [Wed Jun 20 2007, 09:07:11PM EDT]
>> On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote:
>>
>>> akpm@linux-foundation.org wrote: [Wed Jun 20 2007, 01:14:34PM EDT]
>>> [snip]
>>>
>>> Build breakage. pci_mmcfg_late_init is for i386.
>> then you want CONFIG_X86_32 instead of CONFIG_X86.
>> CONFIG_X86 is set/true for both X86_32 and X86_64.
> Then what I stated within the patch description is incorrect. pci.h which is the
> required include for the declaration is conditionally for CONFIG_X86. So it is
> both I guess?
Yes.
> bob
>>
>>> Signed-off-by: Bob Picco <bob.picco@hp.com>
>>>
>>> drivers/acpi/bus.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
>>> ===================================================================
>>> --- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c 2007-06-20 14:09:07.000000000 -0400
>>> +++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c 2007-06-20 20:32:00.000000000 -0400
>>> @@ -757,7 +757,9 @@ static int __init acpi_init(void)
>>> result = acpi_bus_init();
>>>
>>> if (!result) {
>>> +#ifdef CONFIG_X86
>>> pci_mmcfg_late_init();
>>> +#endif
>>> #ifdef CONFIG_PM_LEGACY
>>> if (!PM_IS_ACTIVE())
>>> pm_active = 1;
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-06-21 4:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 17:14 mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded akpm
2007-06-20 18:45 ` [PATCH] fs/quota.c build fix (Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded) Michal Piotrowski
2007-06-21 14:17 ` Vasily Tarasov
2007-06-21 0:51 ` mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded Bob Picco
2007-06-21 1:07 ` Randy Dunlap
2007-06-21 1:14 ` Bob Picco
2007-06-21 4:54 ` Randy Dunlap [this message]
2007-06-26 4:12 ` Andrew Morton
2007-06-21 0:52 ` Bob Picco
2007-06-21 2:55 ` Jeremy Fitzhardinge
2007-06-21 3:33 ` Jeremy Fitzhardinge
2007-06-21 23:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467A0474.809@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bob.picco@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox