From: Cedric Le Goater <clg@fr.ibm.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Containers <containers@lists.osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] namespace: ensure clone_flags are always stored in an unsigned long
Date: Fri, 22 Jun 2007 09:16:25 +0200 [thread overview]
Message-ID: <467B7749.6050208@fr.ibm.com> (raw)
In-Reply-To: <m13b0kebar.fsf@ebiederm.dsl.xmission.com>
Eric W. Biederman wrote:
> While working on unshare support for the network namespace I noticed
> we were putting clone flags in an int. Which is weird because the
> syscall uses unsigned long and we at least need an unsigned to
> properly hold all of the unshare flags.
>
> So to make the code consistent, this patch updates the code to use
> unsigned long instead of int for the clone flags in those places
> where we get it wrong today.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
we definitely want to do that. I have a similar patch waiting for
next -mm doing the same.
Acked-by : Cedric Le Goater <clg@fr.ibm.com>
C.
prev parent reply other threads:[~2007-06-22 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 6:46 [PATCH] namespace: ensure clone_flags are always stored in an unsigned long Eric W. Biederman
2007-06-22 7:16 ` Cedric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467B7749.6050208@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox