From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754411AbXFYCuO (ORCPT ); Sun, 24 Jun 2007 22:50:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752425AbXFYCuB (ORCPT ); Sun, 24 Jun 2007 22:50:01 -0400 Received: from nz-out-0506.google.com ([64.233.162.228]:52449 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752625AbXFYCuA (ORCPT ); Sun, 24 Jun 2007 22:50:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=lx1eIQYfNoTSTu0IDg0it96L/e2SEE2avXxielvjlm1CA6CTBvzIxxLIOyonOvWl3YSKLXJMy8WhrrnmrUQrsTRA3dIKPAWE4PQV72nejgKelqqoBz1drwDAElk4xrKcJ0XxHlAaNwNQ1S6X5PrO+b89H+9lr/zfXq6C0DoQDmc= Message-ID: <467F2D53.2000202@gmail.com> Date: Mon, 25 Jun 2007 11:49:55 +0900 From: Tejun Heo User-Agent: Icedove 1.5.0.10 (X11/20070307) MIME-Version: 1.0 To: Robert Hancock CC: Jeff Garzik , Andrew Morton , enricoss@tiscali.it, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH 2.6.22-rc5] libata: add HTS541616J9SA00 to NCQ blacklist References: <467EC909.9040006@shaw.ca> <467F2495.3080509@gmail.com> <467F286B.40607@gmail.com> <467F2ADF.1040600@shaw.ca> In-Reply-To: <467F2ADF.1040600@shaw.ca> X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Robert Hancock wrote: > Tejun Heo wrote: >> Another member of HTS5416* family doing spurious NCQ completion. >> >> Signed-off-by: Tejun Heo >> Cc: Enrico Sardi >> --- >> drivers/ata/libata-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c >> index adfae9d..fbca8d8 100644 >> --- a/drivers/ata/libata-core.c >> +++ b/drivers/ata/libata-core.c >> @@ -3803,6 +3803,7 @@ static const struct ata_blacklist_entry >> ata_device_blacklist [] = { >> /* Drives which do spurious command completion */ >> { "HTS541680J9SA00", "SB2IC7EP", ATA_HORKAGE_NONCQ, }, >> { "HTS541612J9SA00", "SBDIC7JP", ATA_HORKAGE_NONCQ, }, >> + { "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, }, >> { "WDC WD740ADFD-00NLR1", NULL, ATA_HORKAGE_NONCQ, }, >> >> /* Devices with NCQ limits */ >> > > Is that the right ID string? Strange that that one has Hitachi at the > front and the others don't.. Yeah, I realized that and asked Enrico about it. :-) -- tejun